Skip to content

Commit b417bb3

Browse files
Revert "Add model version information"
This reverts commit 897433c.
1 parent 0065e45 commit b417bb3

7 files changed

Lines changed: 1 addition & 10 deletions

File tree

backend/src/acidwatch_api/models/base.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,8 +272,6 @@ def __init_subclass__(cls) -> None:
272272

273273
model_id: Annotated[str, Doc("Unique model identifier")]
274274

275-
version: Annotated[str | None, Doc("Model version")] = None
276-
277275
display_name: Annotated[
278276
str, Doc("User-friendly model name which is displayed in the frontend")
279277
]

backend/src/acidwatch_api/models/datamodel.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ class ModelInfo(BaseModel):
6969

7070
access_error: str | None
7171
model_id: str
72-
version: str | None
7372
display_name: str
7473
description: str
7574
category: str

backend/src/acidwatch_api/models/solubilityccs.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
)
88
from acidwatch_api.models.datamodel import TextResult
99

10-
from solubilityccs import __version__, Fluid, ModelResults # type: ignore
10+
from solubilityccs import Fluid, ModelResults # type: ignore
1111
from solubilityccs.neqsim_functions import get_co2_parameters # type: ignore
1212

1313
DESCRIPTION: str = """Solubility model detects acid formation risks in CO2 streams.
@@ -49,7 +49,6 @@ class SolubilityCCSParameters(BaseParameters):
4949

5050
class SolubilityCCSAdapter(BaseAdapter):
5151
model_id = "solubilityccs"
52-
version = __version__
5352
display_name = "Solubility CCS"
5453
description = DESCRIPTION
5554
valid_substances = ["H2O", "H2SO4", "HNO3"]

backend/src/acidwatch_api/routes/models.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ def get_models(
5252
ModelInfo(
5353
access_error=access_error,
5454
model_id=adapter.model_id,
55-
version=adapter.version,
5655
display_name=adapter.display_name,
5756
category=adapter.category,
5857
description=adapter.description,

backend/tests/test_models_endpoints.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,6 @@ async def run(self):
193193
}
194194
},
195195
"validSubstances": [],
196-
"version": None,
197196
}
198197
]
199198

frontend/src/components/ModelSelect.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ const ModelSelect: React.FC<{ currentModel?: ModelConfig; setCurrentModel: (mode
2929
function getlabel(model: ModelConfig) {
3030
if (model.accessError) {
3131
return `${model.displayName} (accesserror)`;
32-
} else if (model.version) {
33-
return `${model.displayName} (v: ${model.version})`;
3432
}
3533
return model.displayName;
3634
}

frontend/src/dto/FormConfig.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ interface ParameterConfig {
1313
export interface ModelConfig {
1414
accessError?: string;
1515
modelId: string;
16-
version?: string;
1716
displayName: string;
1817
validSubstances: string[];
1918
parameters: Record<string, ParameterConfig>;

0 commit comments

Comments
 (0)