There are always things to do, but here are some I notice after the last days work:
- The components are separated into simulation, grid-simulation and "the rest". We can easily split out for instance plots, and more.
- We have plots and we have charts, pick one and stay with it
- The GridPhaseChart has both a chart and a table. This is an easy split, but also, important to check other similar components.
- The Models page now does too much (after grid simulation was added), the component is like 200 lines long. Much of the content is duplicated depending on if it is grid mode or regular simulation. It would be very good if we could generalise over this.
- Compare page has compare component for simulation inside, while gridsimulation is added to different page. Lets try to place these so that it makes sense. Also, they likely share some functionality.
- the helper function getCo2RichConcentrations is used throughout the codebase. I reckon that we are struggling a bit with the fact that we introduced phases, but for instance the input is always single phase (co2 feed).
- We do in multiple places refer to the first of the simulation results. This hardcoded lookup looks like something that will eventually trip us.
- Several of the files in functions seems out of place, like Tables or GridSimulation (as most of the logic in the simulations are in the component. Perhaps its the other way round, the functions directory should have more logic related to simulations. Regardless, it's not consistent)
A simulation is just a subset of a simulation, lets see if we can incorporate that into the code.
Edit: also noticed that for the backend the routes folder is getting off. It contains a models.py and a gridsimulation.py. Both of them do simulations and gridsimulation.py uses things from models.py. Essentially, both naming of the files and the content of them is off. Requires a bit of restructure.
There are always things to do, but here are some I notice after the last days work:
A simulation is just a subset of a simulation, lets see if we can incorporate that into the code.
Edit: also noticed that for the backend the routes folder is getting off. It contains a models.py and a gridsimulation.py. Both of them do simulations and gridsimulation.py uses things from models.py. Essentially, both naming of the files and the content of them is off. Requires a bit of restructure.