fix(components): Divider accessibility defaults can't be overridden - #224

@claude review

Claude finished @Chibuzor-Nwemambu's task in 53s —— View job

Review: PR #224 — Divider accessibility defaults can't be overridden

• Gather context (diff, files)
• Analyze the fix and test
• Post review feedback

Verdict: LGTM. The fix is correct, minimal, and well-targeted. ✅

The fix

<View
    style={[styles.divider, style]}
    {...rest}
    accessible={false}
    importantForAccessibility="no"
/>

Moving {...rest} above the accessibility props is exactly right — in JSX, later props win, so the component's own defaults now always take precedence over anything a caller spreads in. This resolves #219.

The approach is also consistent with existing code in the package: Search.tsx already places {...rest} (line 166) before its hardcoded accessible={false} / importantForAccessibility="no" (lines 198–225), so this brings Divider in line with the established pattern.

The test

The regression test (Divider.test.tsx:25–36) is on point — it passes accessible={true} and importantForAccessibility="yes" and asserts both are still forced to the hidden values, directly locking in the intended behavior. Good coverage.

Non-blocking observations

1. Type honesty (minor). DividerProps = ViewProps still advertises accessible and importantForAccessibility as settable props, but they are now silently ignored. A caller reading only the types wouldn't know their value has no effect. If you want the type to reflect reality, you could narrow it:

   export type DividerProps = Omit<ViewProps, "accessible" | "importantForAccessibility">;

   I'd treat this as optional — the sibling components (Search, TextArea) don't do this either, so leaving it keeps things uniform. Worth a line on the #152 tracking issue if you want to standardize the whole set later rather than one-off here.

2. importantForAccessibility is Android-only, and accessible={false} covers iOS — so the two together correctly hide the decorative divider on both platforms. No action needed; just confirming the pair is intentional and complete.

Nice, tightly-scoped fix with a matching regression test. 👍
· 219-divider-allow-overriding-bug