Commit 52b9dc7
fix: address Input component review feedback
- Remove incorrect placeholder color override in readonly state (lines 102-106)
This was creating a CSS variable scoping issue where placeholder used
the default color instead of readonly color
- Add test for readonly + invalid showing neutral appearance
- Add test for error icon hidden in readonly + invalid state
Addresses review feedback on PR #4531
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent 737c27b commit 52b9dc7
2 files changed
Lines changed: 15 additions & 6 deletions
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
130 | 139 | | |
131 | 140 | | |
132 | 141 | | |
| |||
208 | 217 | | |
209 | 218 | | |
210 | 219 | | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
211 | 226 | | |
212 | 227 | | |
213 | 228 | | |
| |||
Lines changed: 0 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | 101 | | |
108 | 102 | | |
109 | 103 | | |
| |||
0 commit comments