fix: preserve user-provided id on Autocomplete input (#4682)

* fix: preserve user-provided id on Autocomplete input

Pass user-provided id as inputId to downshift's useCombobox so it is
used consistently for the input element, label htmlFor, and all
related aria attributes. Closes #4588

* fix: for pull request finding 'Unused variable, import, function or class'

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

* fix: address review feedback on Autocomplete id test

Remove unused variable and use getByRole instead of container
querySelector to satisfy testing-library lint rules.

* fix: restore lost changes and snapshot from rebase

Re-apply inputId fix in useAutocomplete and test cases that were
lost during rebase. Restore snapshot from main to match CI environment.

---------

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Author: pomfrida

packages/eds-core-react/src/components/Autocomplete/Autocomplete.test.tsx

@@ -138,6 +138,21 @@ describe('Autocomplete', () => {
     expect(optionsList.nodeName).toBe('UL')
   })
 
+  it('Preserves user-provided id on the input element', () => {
+    render(<Autocomplete id="my-custom-id" label={labelText} options={items} />)
+    const input = screen.getAllByLabelText(labelText)[0]
+    expect(input).toHaveAttribute('id', 'my-custom-id')
+  })
+
+  it('Maintains label-input association when custom id is provided', () => {
+    render(<Autocomplete id="my-custom-id" label={labelText} options={items} />)
+    // getByRole finds the input via its associated label, confirming the for/id link works
+    expect(screen.getByRole('combobox', { name: labelText })).toHaveAttribute(
+      'id',
+      'my-custom-id',
+    )
+  })
+
   it('Has provided ReactNode label', async () => {
     render(<Autocomplete label={<div>{labelText}</div>} options={items} />)
 

packages/eds-core-react/src/components/Autocomplete/useAutocomplete.ts

@@ -65,6 +65,7 @@ export const useAutocomplete = <T>({
   variant,
   onClear,
   ref,
+  id,
   ...other
 }: AutocompleteProps<T> & { ref?: React.Ref<HTMLInputElement> }) => {
   const [lastScrollOffset, setLastScrollOffset] = useState<number>(0)
@@ -295,6 +296,7 @@ export const useAutocomplete = <T>({
 
   // MARK: downshift state
   let comboBoxProps: UseComboboxProps<T> = {
+    ...(id !== undefined && { inputId: id }),
     items: availableItems as T[], //can not pass readonly type to downshift so we cast it to regular T[]
     initialSelectedItem: initialSelectedOptions[0],
     isItemDisabled(item) {