Skip to content

Commit 90009b9

Browse files
committed
chore: remove none
1 parent ba142f6 commit 90009b9

4 files changed

Lines changed: 27 additions & 77 deletions

File tree

src/libecalc/common/list/list_utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def group_data_by_value_at_index(index: int, row_based_data: list[list[Any]]) ->
6262
return chart_grouped_by_index
6363

6464

65-
def elementwise_sum(*vectors: Sequence[float | None], periods: Periods | None = None) -> NDArray[np.float64]:
65+
def elementwise_sum(*vectors: Sequence[float], periods: Periods | None = None) -> NDArray[np.float64]:
6666
"""Sum up multiple vectors elementwise.
6767
6868
E.g. if we provide three lists [1,20], [2,10], [1,30], the result will be [1+2+1,20+10+30] = [4,60]
@@ -81,11 +81,11 @@ def elementwise_sum(*vectors: Sequence[float | None], periods: Periods | None =
8181
result = np.full_like(vectors[0], fill_value=0.0, dtype=float64)
8282

8383
for vector in vectors:
84-
result = np.add(result, vector) # type: ignore[arg-type]
84+
result = np.add(result, vector)
8585
return result
8686

8787

88-
def elementwise_multiplication(*vectors: Sequence[float | None], periods: Periods | None = None) -> NDArray[np.float64]:
88+
def elementwise_multiplication(*vectors: Sequence[float], periods: Periods | None = None) -> NDArray[np.float64]:
8989
"""Multiply multiple vectors elementwise.
9090
9191
E.g. if we provide three lists [1,20], [2,10], [1,30], the result will be [1*2*1,20*10*30] = [2,6000]
@@ -104,7 +104,7 @@ def elementwise_multiplication(*vectors: Sequence[float | None], periods: Period
104104
result = np.full_like(vectors[0], fill_value=1.0, dtype=float64)
105105

106106
for vector in vectors:
107-
result = np.multiply(result, vector) # type: ignore[arg-type]
107+
result = np.multiply(result, vector)
108108
return result
109109

110110

src/libecalc/common/utils/rates.py

Lines changed: 2 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
from __future__ import annotations
22

3-
import math
43
from abc import ABC
54
from collections import defaultdict
65
from collections.abc import Iterable, Iterator
76
from datetime import datetime
87
from enum import Enum
9-
from typing import Any, Generic, Self, TypeVar, Union
8+
from typing import Generic, Self, TypeVar, Union
109

1110
import numpy as np
1211
import pandas as pd
@@ -462,27 +461,12 @@ def __mul__(self, other: object) -> Self:
462461
)
463462

464463

465-
class TimeSeriesFloat(TimeSeries[float]):
466-
@field_validator("values", mode="before")
467-
@classmethod
468-
def convert_none_to_nan(cls, v: Any) -> list[TimeSeriesValue]:
469-
if isinstance(v, list):
470-
# convert None to nan
471-
return [i if i is not None else math.nan for i in v] # type: ignore[misc]
472-
return v
464+
class TimeSeriesFloat(TimeSeries[float]): ...
473465

474466

475467
class TimeSeriesVolumesCumulative(TimeSeries[float]):
476468
"""This will represent the sum of the volumes in all periods up to and including each individual period."""
477469

478-
@field_validator("values", mode="before")
479-
@classmethod
480-
def convert_none_to_nan(cls, v: Any) -> list[TimeSeriesValue]:
481-
if isinstance(v, list):
482-
# convert None to nan
483-
return [i if i is not None else math.nan for i in v] # type: ignore[misc]
484-
return v
485-
486470
def resample(
487471
self, freq: Frequency, include_start_date: bool = True, include_end_date: bool = True
488472
) -> TimeSeriesVolumesCumulative:
@@ -573,14 +557,6 @@ def to_volumes(self) -> TimeSeriesVolumes:
573557

574558

575559
class TimeSeriesVolumes(TimeSeries[float]):
576-
@field_validator("values", mode="before")
577-
@classmethod
578-
def convert_none_to_nan(cls, v: Any) -> list[TimeSeriesValue]:
579-
if isinstance(v, list):
580-
# convert None to nan
581-
return [i if i is not None else math.nan for i in v] # type: ignore[misc]
582-
return v
583-
584560
def resample(self, freq: Frequency, include_start_date: bool = True, include_end_date: bool = True):
585561
"""
586562
Resample the time series of period volumes to a new frequency or set of periods.
@@ -729,14 +705,6 @@ class TimeSeriesRate(TimeSeries[float]):
729705
rate_type: RateType
730706
regularity: list[float]
731707

732-
@field_validator("values", "regularity", mode="before")
733-
@classmethod
734-
def convert_none_to_nan(cls, v: Any) -> list[TimeSeriesValue]:
735-
if isinstance(v, list):
736-
# convert None to nan
737-
return [i if i is not None else math.nan for i in v] # type: ignore[misc]
738-
return v
739-
740708
@field_validator("regularity")
741709
@classmethod
742710
def check_regularity_length(cls, regularity: list[float], info: ValidationInfo) -> list[float]:

src/libecalc/domain/process/core/results/compressor.py

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,15 @@ class TargetPressureStatus(str, Enum):
4747
class CompressorStreamCondition(EnergyModelBaseResult):
4848
def __init__(
4949
self,
50-
pressure: Sequence[float | None] | None = None,
51-
actual_rate_m3_per_hr: Sequence[float | None] | None = None,
52-
actual_rate_before_asv_m3_per_hr: Sequence[float | None] | None = None,
53-
standard_rate_sm3_per_day: Sequence[float | None] | None = None,
54-
standard_rate_before_asv_sm3_per_day: Sequence[float | None] | None = None,
55-
density_kg_per_m3: Sequence[float | None] | None = None,
56-
kappa: Sequence[float | None] | None = None,
57-
z: Sequence[float | None] | None = None,
58-
temperature_kelvin: Sequence[float | None] | None = None,
50+
pressure: Sequence[float] | None = None,
51+
actual_rate_m3_per_hr: Sequence[float] | None = None,
52+
actual_rate_before_asv_m3_per_hr: Sequence[float] | None = None,
53+
standard_rate_sm3_per_day: Sequence[float] | None = None,
54+
standard_rate_before_asv_sm3_per_day: Sequence[float] | None = None,
55+
density_kg_per_m3: Sequence[float] | None = None,
56+
kappa: Sequence[float] | None = None,
57+
z: Sequence[float] | None = None,
58+
temperature_kelvin: Sequence[float] | None = None,
5959
):
6060
super().__init__()
6161
self.pressure = pressure
@@ -87,20 +87,20 @@ def create_empty(cls, number_of_periods) -> CompressorStreamCondition:
8787
class CompressorStageResult(EnergyModelBaseResult):
8888
def __init__(
8989
self,
90-
energy_usage: Sequence[float | None],
90+
energy_usage: Sequence[float],
9191
energy_usage_unit: Unit,
92-
power: Sequence[float | None] | None = None,
92+
power: Sequence[float] | None = None,
9393
power_unit: Unit | None = None,
94-
mass_rate_kg_per_hr: Sequence[float | None] | None = None,
95-
mass_rate_before_asv_kg_per_hr: Sequence[float | None] | None = None,
94+
mass_rate_kg_per_hr: Sequence[float] | None = None,
95+
mass_rate_before_asv_kg_per_hr: Sequence[float] | None = None,
9696
inlet_stream_condition: CompressorStreamCondition = None,
9797
outlet_stream_condition: CompressorStreamCondition = None,
98-
polytropic_enthalpy_change_kJ_per_kg: Sequence[float | None] | None = None,
99-
polytropic_head_kJ_per_kg: Sequence[float | None] | None = None,
100-
polytropic_efficiency: Sequence[float | None] | None = None,
101-
polytropic_enthalpy_change_before_choke_kJ_per_kg: Sequence[float | None] | None = None,
102-
speed: Sequence[float | None] | None = None,
103-
asv_recirculation_loss_mw: Sequence[float | None] = None,
98+
polytropic_enthalpy_change_kJ_per_kg: Sequence[float] | None = None,
99+
polytropic_head_kJ_per_kg: Sequence[float] | None = None,
100+
polytropic_efficiency: Sequence[float] | None = None,
101+
polytropic_enthalpy_change_before_choke_kJ_per_kg: Sequence[float] | None = None,
102+
speed: Sequence[float] | None = None,
103+
asv_recirculation_loss_mw: Sequence[float] = None,
104104
fluid_composition: dict[str, float | None] = None,
105105
is_valid: Sequence[bool] = None,
106106
chart_area_flags: Sequence[str] = None,
@@ -182,8 +182,8 @@ class CompressorTrainResult(EnergyFunctionResult):
182182

183183
def __init__(
184184
self,
185-
rate_sm3_day: Sequence[float | None] | list[list[float]],
186-
max_standard_rate: Sequence[float | None] | list[list[float]] | None = None,
185+
rate_sm3_day: Sequence[float] | list[list[float]],
186+
max_standard_rate: Sequence[float] | list[list[float]] | None = None,
187187
inlet_stream_condition: CompressorStreamCondition = None,
188188
outlet_stream_condition: CompressorStreamCondition = None,
189189
stage_results: Sequence[CompressorStageResult] = None,

tests/libecalc/common/utils/test_rates.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -298,24 +298,6 @@ def test_resample_missing_year(self):
298298

299299

300300
class TestTimeSeriesRate:
301-
def test_none_value_timeseriesrate(self):
302-
rate1 = TimeSeriesRate(
303-
periods=Periods(
304-
[
305-
Period(
306-
start=datetime(2023, 1, 1),
307-
end=datetime(2023, 6, 1),
308-
)
309-
]
310-
),
311-
values=[10] * 1,
312-
regularity=[None],
313-
unit=Unit.STANDARD_CUBIC_METER_PER_DAY,
314-
rate_type=RateType.STREAM_DAY,
315-
)
316-
317-
assert np.isnan(rate1.regularity)
318-
319301
def test_adding_timeseriesrate(self):
320302
rate1 = TimeSeriesRate(
321303
periods=Periods.create_periods(

0 commit comments

Comments
 (0)