ci: trigger publish via on_workflow_run event

It is the only way to set the correct "owner workflow", as it is
not embedded in another, as when using workflow_call.

Refs: equinor/ecalc-internal#433

Author: tj098895

.github/workflows/on-push-main-branch.yml

@@ -26,6 +26,8 @@ jobs:
     uses: ./.github/workflows/docs-publish.yml
     secrets: inherit
 
-  release-please:
-    uses: ./.github/workflows/release-please.yml
-    secrets: inherit
+# NOTE: We trigger release-please in the on_workflow_run instead, freeing it from this workflow,
+# and creating a separate workflow for it, that we again can listen to and trigger the publish workflow from.
+# Also, we want to build and test the library before we trigger the release-please workflow,
+# so that we can be sure that the library is in a good state before we release it, and instead of doing it twice,
+# we wait until that is done on the main branch first.

.github/workflows/publish.yml

@@ -2,10 +2,11 @@ name: Publish libeCalc package to PyPI
 
 on:
   workflow_run:
-    workflows: [trigger-publish]
+    workflows: [release-please]
     types:
       - completed
-  # Note! We cannot trigger on published event, since that can only be triggered when done manually.
+  # Note! We cannot trigger on published event, since that can only be triggered when done manually (or with a
+  # separate PAT token, not the standard GITHUB_TOKEN), and we want to use the standard GITHUB_TOKEN).
   # Therefore we trigger this workflow independently, after the trigger-publish workflow has run, in
   # order for this workflow to be the owner of the PyPI publishing job, and can be verified. This limits
   # us to only allow this workflow to be allowed to publish to PyPI trustedly.
@@ -17,6 +18,8 @@ on:
 
 jobs:
   publish:
+    # NOTE: Only run if release-please creates a release, ie. it successfully ends
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
     environment:
       name: pypi
       url: https://pypi.org/project/libecalc/

.github/workflows/release-please.yml

@@ -2,7 +2,10 @@ name: release-please
 
 on:
   workflow_dispatch: # Workflow dispatch is used for manual triggers.
-  workflow_call: # Workflow call is used for called from another workflow.
+  workflow_run:
+    workflows: [ on-push-main-branch ]
+    types:
+      - completed
 
 jobs:
   release-please:
@@ -18,7 +21,11 @@ jobs:
       release_created: ${{ steps.release.outputs.release_created }}
       tag_name: ${{ steps.release.outputs.tag_name }}
 
-  deploy_prod:
-    needs: release-please
-    uses: ./.github/workflows/trigger-publish.yml
-    if: ${{ needs.release-please.outputs.release_created }}
+  no-release-created:
+    if: ${{ needs.release-please.outputs.release_created == 'false' }}
+    runs-on: ubuntu-24.04
+    steps:
+      - name: No release created
+        run: |
+          echo "No release created, setting output to false, to avoid triggering publish workflow."
+          exit 1