chore: use list of periods instead of cumbersome periods class (#1573)

Refs: equinor/ecalc-internal#1833

Author: tj098895

src/libecalc/ecalc_model/process_simulation.py

@@ -4,7 +4,7 @@
 
 from libecalc.common.ddd import value_object
 from libecalc.common.ddd.entity import Entity
-from libecalc.common.time_utils import Periods
+from libecalc.common.time_utils import Period
 from libecalc.common.utils.ecalc_uuid import ecalc_id_generator
 from libecalc.ecalc_model.time_series_configuration import (
     TimeSeriesPressureDropperConfiguration,
@@ -105,7 +105,7 @@ def __init__(
         name: str,
         stream_distribution: CommonStreamDistributionConfig | IndividualStreamDistributionConfig,
         process_problems: list[ProcessProblem],
-        process_periods: Periods,
+        process_periods: list[Period],
         process_simulation_id: ProcessSimulationId | None = None,
         process_configurations: dict[
             ProcessPipelineId,
@@ -123,7 +123,12 @@ def __init__(
     def get_id(self) -> ProcessSimulationId:
         return self._id
 
-    def get_process_periods(self) -> Periods:
+    def get_process_periods(self) -> list[Period]:
+        """
+        Get the global period vector - where START, END is taken into account, all temporal events (in legacy YAML) and relevant timeseries.
+        Returns:
+
+        """
         return self.process_periods
 
     def get_name(self) -> str:

src/libecalc/presentation/yaml/domain/time_series_expression.py

@@ -1,5 +1,6 @@
 import numpy as np
 
+from libecalc.common.time_utils import Period
 from libecalc.common.variables import ExpressionEvaluator
 from libecalc.dto.utils.validators import convert_expression
 from libecalc.expression.expression import Expression, ExpressionType
@@ -68,3 +69,12 @@ def get_masked_values(self) -> list[float]:
     def get_condition_mask(self) -> TimeSeriesMask:
         mask = self.expression_evaluator.evaluate(expression=self._condition) if self._condition is not None else None
         return TimeSeriesMask.from_array(mask)
+
+    def get_periods(self) -> list[Period]:
+        """
+        Returns the periods where this expression is evaluated for
+
+        Returns:
+
+        """
+        return self.expression_evaluator.get_periods().periods

src/libecalc/presentation/yaml/mappers/process_simulation_mapper.py

@@ -3,7 +3,7 @@
 
 from libecalc.common.errors.ecalc_validation_error import EcalcValidationException
 from libecalc.common.errors.exceptions import InvalidResourceException
-from libecalc.common.time_utils import Period, Periods
+from libecalc.common.time_utils import Period
 from libecalc.common.units import Unit
 from libecalc.common.variables import ExpressionEvaluator
 from libecalc.domain.process.value_objects.chart.chart import ChartData
@@ -300,7 +300,7 @@ def map_anti_surge_strategy(
                 assert_never(recirculation_type)
 
     def map_process_simulation(
-        self, yaml_process_simulation: YamlProcessSimulation, process_periods: Periods
+        self, yaml_process_simulation: YamlProcessSimulation, process_periods: list[Period]
     ) -> tuple[list[ProcessPipeline], ProcessSimulation]:
         process_pipelines: list[ProcessPipeline] = []
         constraints: dict[ProcessPipelineId, Constraint] = {}

src/libecalc/presentation/yaml/model.py

@@ -163,7 +163,7 @@ def get_process_simulations(self) -> tuple[list[ProcessPipeline], list[ProcessSi
 
         return process_pipelines, process_simulations
 
-    def get_periods(self) -> Periods:
+    def get_periods(self) -> list[Period]:
         """
         Get the global timevector for this model
         """
@@ -272,7 +272,7 @@ def _get_periods(self, time_series_time_vector: Iterable[datetime]) -> Periods:
                 additional_dates=set(self._configuration.dates),
             )
             periods = Periods.create_periods(time_vector, include_before=False, include_after=False)
-            self._global_periods = periods
+            self._global_periods = periods.periods
             return periods
         except InvalidEndDate as e:
             location_keys = ("END",)