Skip to content

Commit a093dcb

Browse files
committed
#3440 magazine card UI fixes and alignment
1 parent acc9189 commit a093dcb

3 files changed

Lines changed: 4 additions & 9 deletions

File tree

web/sections/cards/Card/Card.tsx

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,14 @@ export const Card = forwardRef<HTMLAnchorElement, CardProps>(function Card(
4545
) {
4646
const commonStyling = `
4747
grid
48-
grid-cols-1
49-
grid-rows-[35%_65%]
50-
flex-col
51-
gap-0
5248
rounded-card
5349
w-full
5450
h-full
5551
`
5652

5753
const variantClassNames: Record<Variants, string> = {
58-
primary: `${commonStyling}`,
59-
secondary: `${commonStyling}`,
54+
primary: `${commonStyling} grid-rows-[auto_1fr]`,
55+
secondary: `${commonStyling} grid-rows-[auto_1fr]`,
6056
compact: `w-full h-full rounded-card flex gap-4`,
6157
single: `grid grid-cols-[40%_auto] min-h-[450px] rounded-card`,
6258
}
@@ -108,4 +104,4 @@ export const Card = forwardRef<HTMLAnchorElement, CardProps>(function Card(
108104
{children}
109105
</BaseLink>
110106
)
111-
})
107+
})

web/sections/cards/Card/CardContent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export const CardContent = forwardRef<HTMLDivElement, CardContentProps>(
4747
<div
4848
ref={ref}
4949
className={twMerge(
50-
`flex h-full gap-4 md:gap-6 ${variantClassNames[variant]}`,
50+
`flex gap-4 md:gap-6 ${variantClassNames[variant]}`,
5151
className,
5252
)}
5353
>

web/sections/cards/MagazineCard/MagazineCard.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ const MagazineCard = forwardRef<HTMLAnchorElement, MagazineCardProps>(
2424
image={hero?.figure?.image}
2525
variant={'primary'}
2626
className={twMerge(`h-full w-full`, className)}
27-
imageWrapperClassName='h-[45%]'
2827
key={id}
2928
>
3029
<Card.Content variant={'primary'}>

0 commit comments

Comments
 (0)