Add distribution connection line control

The connection line toggle disappeared with the plot customization
dialog. Reintroduce it in the plot sidebar alongside the statistics
controls.

Author: MagnusSletten

src/ert/gui/plotting/plot_window.py

@@ -62,6 +62,7 @@
 from .widgets.everest_control_selection_widget import EverestControlSelectionWidget
 from .widgets.plot_controls import (
     BoxplotOptions,
+    DistributionOptions,
     EverestControlsPlotOptions,
     GeneralPlotOptions,
     StatisticsOptions,
@@ -302,6 +303,7 @@ def __init__(
             self._general_options.titleEditRequested.connect(self._edit_title)
             self._boxplot_options = BoxplotOptions(self.update_plot)
             self._statistics_options = StatisticsOptions(self.update_plot)
+            self._distribution_options = DistributionOptions(self.update_plot)
 
             right_container = QWidget()
             right_layout = create_group_layout(
@@ -312,6 +314,7 @@ def __init__(
                     self._everest_controls_group,
                     self._boxplot_options.get_widget(),
                     self._statistics_options.get_widget(),
+                    self._distribution_options.get_widget(),
                 ]
             )
             right_container.setLayout(right_layout)
@@ -320,6 +323,7 @@ def __init__(
             self._everest_controls_plot_options.get_widget().setVisible(False)
             self._boxplot_options.get_widget().setVisible(False)
             self._statistics_options.get_widget().setVisible(False)
+            self._distribution_options.get_widget().setVisible(False)
             self._data_type_keys_widget.selectDefault()
 
             splitter = QSplitter(Qt.Orientation.Horizontal)
@@ -388,6 +392,9 @@ def update_plot(self, layer: int | None = None) -> None:
             plot_widget.name in {MISFITS, CROSS_ENSEMBLE_STATISTICS}
         )
         self._statistics_options.get_widget().setVisible(plot_widget.name == STATISTICS)
+        self._distribution_options.get_widget().setVisible(
+            plot_widget.name == DISTRIBUTION
+        )
         self._general_options.get_widget().setVisible(plot_widget.name != STD_DEV)
 
         is_gradient_plot = plot_widget.name == EVEREST_GRADIENTS_PLOT
@@ -548,6 +555,8 @@ def fetch_data(
             plot_config.set_y_label(self._y_labels.get(key_def.key))
             if selected_tab == STATISTICS:
                 self._statistics_options.apply_to(plot_config)
+            elif selected_tab == DISTRIBUTION:
+                self._distribution_options.apply_to(plot_config)
             plot_config.set_legend_enabled(self._general_options.legend_checkbox_state)
             plot_config.set_grid_enabled(self._general_options.grid_checkbox_state)
             plot_config.set_line_color_cycle(self._general_options.get_color_cycle())

src/ert/gui/plotting/widgets/plot_controls/__init__.py

@@ -1,5 +1,6 @@
 from .boxplot_options import BoxplotOptions
 from .custom_palette_dialog import CustomPaletteDialog
+from .distribution_options import DistributionOptions
 from .everest_controls_plot_options import EverestControlsPlotOptions
 from .general_options import GeneralPlotOptions
 from .plot_color_palette_selector import PlotColorPaletteSelector
@@ -8,6 +9,7 @@
 __all__ = [
     "BoxplotOptions",
     "CustomPaletteDialog",
+    "DistributionOptions",
     "EverestControlsPlotOptions",
     "GeneralPlotOptions",
     "PlotColorPaletteSelector",

src/ert/gui/plotting/widgets/plot_controls/distribution_options.py

@@ -0,0 +1,42 @@
+from __future__ import annotations
+
+import logging
+from collections.abc import Callable
+from typing import TYPE_CHECKING
+
+from PyQt6.QtWidgets import QGroupBox
+
+from ert.gui.plotting.utils.qt_creator import (
+    create_checkbox_with_tooltip,
+    create_group_box,
+    create_group_layout,
+)
+
+if TYPE_CHECKING:
+    from ert.gui.plotting.utils import PlotConfig
+
+logger = logging.getLogger(__name__)
+
+
+class DistributionOptions:
+    def __init__(self, connection_point: Callable[..., object]) -> None:
+        self._connection_lines_toggle = create_checkbox_with_tooltip(
+            "Connection lines",
+            "Draw lines between the realizations of neighbouring ensembles",
+            connection_point,
+            initial_checked=False,
+            logger=logger,
+        )
+
+        self._distribution_options = create_group_box(
+            "Distribution options",
+            create_group_layout([self._connection_lines_toggle]),
+        )
+
+    def apply_to(self, plot_config: PlotConfig) -> None:
+        plot_config.set_distribution_line_enabled(
+            self._connection_lines_toggle.isChecked()
+        )
+
+    def get_widget(self) -> QGroupBox:
+        return self._distribution_options

tests/ert/unit_tests/gui/plotting/widgets/test_distribution_options.py

@@ -0,0 +1,31 @@
+from unittest.mock import Mock
+
+from ert.gui.plotting.utils import PlotConfig
+from ert.gui.plotting.widgets.plot_controls.distribution_options import (
+    DistributionOptions,
+)
+
+
+def test_that_connection_lines_toggle_controls_distribution_lines_in_plot_config(qtbot):
+    options = DistributionOptions(Mock())
+    qtbot.addWidget(options.get_widget())
+
+    assert not options._connection_lines_toggle.isChecked()
+    disabled_config = PlotConfig()
+    options.apply_to(disabled_config)
+    assert not disabled_config.is_distribution_line_enabled()
+
+    options._connection_lines_toggle.setChecked(True)
+    enabled_config = PlotConfig()
+    options.apply_to(enabled_config)
+    assert enabled_config.is_distribution_line_enabled()
+
+
+def test_that_toggling_connection_lines_invokes_the_connection_point(qtbot):
+    connection_point = Mock()
+    options = DistributionOptions(connection_point)
+    qtbot.addWidget(options.get_widget())
+
+    options._connection_lines_toggle.setChecked(True)
+
+    connection_point.assert_called()