Raise ConfigValidationError when absolute path is provided as output file

Author: xjules

src/ert/config/gen_kw_config.py

@@ -104,6 +104,11 @@ def templates_from_config(
                     f"can use GEN_KW with just the distribution file instead: GEN_KW {gen_kw_key} {token}",
                     positional_args[1],
                 )
+            if output_file.startswith("/"):
+                raise ConfigValidationError.with_context(
+                    f"Output file cannot have an absolute path {output_file}",
+                    positional_args[2],
+                )
             return template_file, output_file
         return None
 

tests/ert/unit_tests/storage/test_parameter_sample_types.py

@@ -505,15 +505,15 @@ def test_gen_kw_templating(
 
 @pytest.mark.usefixtures("set_site_config")
 @pytest.mark.parametrize(
-    "relpath",
+    "relpath, err_msg",
     [
-        "somepath/",
+        ("somepath/", ""),
         # This test was added to show current behaviour for Ert.
         # If absolute paths should be possible to be used like this is up for debate.
-        "/tmp/somepath/",  # ert removes leading '/'
+        ("/tmp/somepath/", "Output file cannot have an absolute path"),
     ],
 )
-def test_gen_kw_outfile_will_use_paths(tmpdir, storage, relpath: str):
+def test_gen_kw_outfile_will_use_paths(tmpdir, storage, relpath: str, err_msg: str):
     with tmpdir.as_cwd():
         config = dedent(
             f"""
@@ -530,8 +530,15 @@ def test_gen_kw_outfile_will_use_paths(tmpdir, storage, relpath: str):
         with open("prior.txt", mode="w", encoding="utf-8") as fh:
             fh.writelines("MY_KEYWORD NORMAL 0 1")
         relpath = relpath.removeprefix("/")
-        create_runpath(storage, "config.ert")
-        assert os.path.exists(f"simulations/realization-0/iter-0/{relpath}kw.txt")
+        if err_msg:
+            with pytest.raises(
+                ConfigValidationError,
+                match=err_msg,
+            ):
+                create_runpath(storage, "config.ert")
+        else:
+            create_runpath(storage, "config.ert")
+            assert os.path.exists(f"simulations/realization-0/iter-0/{relpath}kw.txt")
 
 
 @pytest.mark.usefixtures("set_site_config")