fixup! Add tests for seismic misfit plot

Author: akustn

tests/ert/unit_tests/gui/plotting/ert_plots/test_misfits_plot.py

@@ -1,4 +1,5 @@
 from datetime import datetime
+from itertools import starmap
 
 import pandas as pd
 import polars as pl
@@ -149,27 +150,54 @@ def test_that_misfit_conversion_for_summary_converts_to_equivalent_long_polars_d
     assert_frame_equal(result_df, expected_df)
 
 
+@pytest.mark.parametrize(
+    ("data_origin", "key", "ensemble_specs", "ensemble_frames", "observation_data"),
+    [
+        pytest.param(
+            "summary",
+            "FOPR",
+            [("ensemble",)],
+            [{"2023-01-01": [12.0]}],
+            {0: [1.0, 10.0, "2023-01-02"]},
+            id="summary_key_index_mismatch",
+        ),
+        pytest.param(
+            "seismic",
+            "SEISMIC_KEY",
+            [
+                ("ensemble_empty_1", "ensemble_empty_id_1"),
+                ("ensemble_empty_2", "ensemble_empty_id_2"),
+            ],
+            [{"99": [1.0], "100": [2.0]}, {"99": [3.0], "100": [4.0]}],
+            {0: [10.0, 100.0, "0"], 1: [10.0, 200.0, "5"]},
+            id="seismic_key_index_mismatch_all_ensembles",
+        ),
+    ],
+)
 def test_that_misfits_plot_is_empty_when_no_misfit_data_is_available(
-    make_ensemble, make_plot_context, make_key_def
+    data_origin,
+    key,
+    ensemble_specs,
+    ensemble_frames,
+    observation_data,
+    make_ensemble,
+    make_plot_context,
+    make_key_def,
 ):
-    ensemble = make_ensemble("ensemble")
-    plot_context = make_plot_context([ensemble])
-    key_def = make_key_def()
+    ensembles = list(starmap(make_ensemble, ensemble_specs))
+    plot_context = make_plot_context(ensembles, key=key)
+    key_def = make_key_def(key=key, data_origin=data_origin)
     figure = Figure()
 
     MisfitsPlot().plot(
         figure,
         plot_context,
         {
-            ensemble: pd.DataFrame(
-                {"2023-01-01": [12.0]},
-                index=pd.Index([0], name="Realization"),
-            )
+            ensemble: pd.DataFrame(frame, index=pd.Index([0], name="Realization"))
+            for ensemble, frame in zip(ensembles, ensemble_frames, strict=True)
         },
         observation_data=pd.DataFrame(
-            data={
-                0: [1.0, 10.0, "2023-01-02"],
-            },
+            data=observation_data,
             index=["STD", "OBS", "key_index"],
         ),
         std_dev_images={},
@@ -561,46 +589,3 @@ def test_that_seismic_misfit_plot_skips_ensembles_with_no_misfit_data(
     assert xtick_labels == ["ensemble"]
     assert len(figure.axes[0].patches) == 1
     assert figure.axes[0].get_xlim() == (-0.5, 0.5)
-
-
-def test_that_seismic_misfit_plot_is_empty_when_no_ensemble_has_misfits(
-    make_ensemble, make_plot_context, make_key_def
-):
-    ensembles = [
-        make_ensemble("ensemble_empty_1", "ensemble_empty_id_1"),
-        make_ensemble("ensemble_empty_2", "ensemble_empty_id_2"),
-    ]
-    plot_context = make_plot_context(
-        ensembles, key="SEISMIC_KEY", plot_config=PlotConfig(title=None)
-    )
-    key_def = make_key_def(key="SEISMIC_KEY", data_origin="seismic")
-
-    figure = Figure()
-
-    MisfitsPlot().plot(
-        figure,
-        plot_context,
-        {
-            ensembles[0]: pd.DataFrame(
-                {"99": [1.0], "100": [2.0]},
-                index=pd.Index([0], name="Realization"),
-            ),
-            ensembles[1]: pd.DataFrame(
-                {"99": [3.0], "100": [4.0]},
-                index=pd.Index([0], name="Realization"),
-            ),
-        },
-        observation_data=pd.DataFrame(
-            data={
-                0: [10.0, 100.0, "0"],
-                1: [10.0, 200.0, "5"],
-            },
-            index=["STD", "OBS", "key_index"],
-        ),
-        std_dev_images={},
-        obs_loc=None,
-        key_def=key_def,
-    )
-
-    assert len(figure.axes) == 1
-    assert figure.axes[0].texts[0].get_text() == "No misfit data available"