Fix ruff rule RUF075

See https://docs.astral.sh/ruff/rules/fallible-context-manager/

Author: larsevj

src/ert/gui/tools/event_viewer/panel.py

@@ -92,7 +92,7 @@ def add_gui_log_handler() -> Iterator[GUILogHandler]:
 
     gui_handler = GUILogHandler()
     logger.addHandler(gui_handler.handler)
-
-    yield gui_handler
-
-    logger.removeHandler(gui_handler.handler)
+    try:
+        yield gui_handler
+    finally:
+        logger.removeHandler(gui_handler.handler)

tests/ert/ui_tests/gui/conftest.py

@@ -104,8 +104,10 @@ def _open_main_window(path) -> Iterator[tuple[ErtMainWindow, Storage, ErtConfig]
             add_gui_log_handler() as log_handler,
         ):
             gui = _setup_main_window(config, args_mock, log_handler, config.ens_path)
-            yield gui, config.ens_path, config
-            gui.close()
+            try:
+                yield gui, config.ens_path, config
+            finally:
+                gui.close()
 
 
 @pytest.fixture

tests/ert/ui_tests/gui/test_breakthrough_visualization.py

@@ -113,10 +113,10 @@ def open_plotter(config: ErtConfig, qtbot: QtBot):
 
         qtbot.mouseClick(button_plot_tool, Qt.MouseButton.LeftButton)
         plot_window = get_child(gui, PlotWindow)
-
-        yield plot_window
-
-        plot_window.close()
+        try:
+            yield plot_window
+        finally:
+            plot_window.close()
 
 
 def setup_storage(config):

tests/ert/ui_tests/gui/test_restart_no_responses_and_parameters.py

@@ -68,8 +68,10 @@ def _open_main_window(
     # RuntimeError: wrapped C/C++ object of type GUILogHandler
     handler = GUILogHandler()
     gui = _setup_main_window(config, args_mock, handler, config.ens_path)
-    yield gui, config.ens_path, config
-    gui.close()
+    try:
+        yield gui, config.ens_path, config
+    finally:
+        gui.close()
 
 
 @pytest.fixture

tests/ert/ui_tests/gui/test_workflow_tool.py

@@ -41,8 +41,10 @@ def _open_main_window(
     # RuntimeError: wrapped C/C++ object of type GUILogHandler
     handler = GUILogHandler()
     gui = _setup_main_window(config, args_mock, handler, config.ens_path)
-    yield gui
-    gui.close()
+    try:
+        yield gui
+    finally:
+        gui.close()
 
 
 @pytest.fixture

tests/ert/unit_tests/dark_storage/conftest.py

@@ -81,8 +81,10 @@ def dark_storage_app_(monkeypatch):
     monkeypatch.setenv("ERT_STORAGE_NO_TOKEN", "yup")
     monkeypatch.setenv("ERT_STORAGE_ENS_PATH", "storage")
 
-    yield app
-    reset_dark_storage()
+    try:
+        yield app
+    finally:
+        reset_dark_storage()
 
 
 @pytest.fixture

tests/ert/unit_tests/resources/test_shell.py

@@ -20,10 +20,10 @@
 def pushd(path):
     cwd0 = Path.cwd()
     os.chdir(path)
-
-    yield
-
-    os.chdir(cwd0)
+    try:
+        yield
+    finally:
+        os.chdir(cwd0)
 
 
 symlink = import_from_location(