Add new subsystem test for ZMQ+LSF

Author: flikka

ci/testkomodo.sh

@@ -92,7 +92,50 @@ run_everest_eightcells_test() {
     return $STATUS
 }
 
+run_ert-zmq-lsf_test () {
+    set -e
+    if [[ "$CI_RUNNER_LABEL" == "azure" ]]; then
+        echo "Don't run ert-zmq-lsf test on azure"
+        return 0
+    elif [[ "$CI_RUNNER_LABEL" == "onprem" ]]; then
+        RUNNER_ROOT="/scratch/oompf/ert_zmq_lsf_tests"
+    else
+        echo "Unsupported runner label: $CI_RUNNER_LABEL"
+        return 1
+    fi
 
+    rm -rf "$RUNNER_ROOT"
+    mkdir -p "$RUNNER_ROOT"
+    run_path=$(mktemp -d -p "$RUNNER_ROOT")
+    chmod ugo+rx "$run_path"
+
+    pushd "$run_path"
+
+    # Need to create a komodoenv on a network mapped drive for LSF etc.
+    source "${_KOMODO_ROOT}"/"${_FULL_RELEASE_NAME}"/enable
+    komodoenv --root "${_KOMODO_ROOT}" -r "${_FULL_RELEASE_NAME}" --no-update --force test-kenv
+    source test-kenv/enable
+    check_queue "$CI_RUNNER_LABEL"
+
+    # Install the package
+    pip install --upgrade pip
+    pip install ${CI_SOURCE_ROOT}[dev]
+
+    # release_name=$(echo "$_FULL_RELEASE_NAME" | cut --delimiter=- --fields=1)
+    # set +o errexit
+
+    # Run the tests
+    mkdir -p pytest-tmp
+    basetemp="pytests-tmp"
+
+    echo "Created basetemp directory at: $basetemp"
+    pytest -vvs --lsf --basetemp="$basetemp" ${CI_TEST_ROOT}/tests/ert/unit_tests/forward_model_runner/test_fm_dispatch_with_lsf.py
+    return_code_ert_zmq_lsf_tests=$?
+    echo "set folder $basetemp readable for all users"
+    chmod -R a+rwx "$basetemp"
+    # rm -rf ${RUNNER_ROOT} || true
+    return $return_code_ert_zmq_lsf_tests
+}
 
 start_tests() {
     export NO_PROXY=localhost,127.0.0.1
@@ -131,6 +174,9 @@ start_tests() {
       return_code_ert_scheduler_tests=$?
       rm -rf "$basetemp" || true
       return $return_code_ert_scheduler_tests
+    elif [ "$CI_SUBSYSTEM_TEST" == "ert-zmq-lsf" ]; then
+      run_ert-zmq-lsf_test
+      return $?
     elif [ "$CI_SUBSYSTEM_TEST" == "opm-integration" ]; then
       run_ert_with_opm
       return $?
@@ -142,6 +188,6 @@ start_tests() {
     else
       echo "Error: Variable $CI_SUBSYSTEM_TEST did not match any testable subsystem"
     fi
-    echo "Possible subsystems are: ert, everest, everest-eightcells, ert-limit-memory, ert-queue-system, opm-integration"
+    echo "Possible subsystems are: ert, everest, everest-eightcells, ert-limit-memory, ert-queue-system, ert-zmq-lsf, opm-integration"
     return 1
 }

tests/ert/unit_tests/forward_model_runner/test_fm_dispatch_with_lsf.py

@@ -18,7 +18,8 @@ class TCPMockZMQServer(MockZMQServer):
     def __init__(self, signal=0, port_range=(51820, 51840)) -> None:
         super().__init__(signal)
         # Need to use public IP on some clusters
-        self.host = get_ip_address()
+        self.host = get_ip_address(prioritize_private=True)
+        print(f"Using host {self.host}")
         self.port = port_range[0]
         self.min_port = port_range[0]
         self.max_port = port_range[1]
@@ -96,7 +97,7 @@ async def test_that_job_submitted_job_sends_start_and_success_events_to_zmq_serv
 
         driver = LsfDriver()
 
-        fm_dispatch_path = shutil.which("fm_dispatch.py") or "fm_dispatch.py"
+        fm_dispatch_path = shutil.which("fm_dispatch.py")
         await driver.submit(
             0, fm_dispatch_path, str(runpath.absolute()), runpath=runpath
         )
@@ -129,3 +130,4 @@ async def poll_until_done():
         event_types = {json.loads(msg).get("event_type") for msg in zmq_server.messages}
         assert "forward_model_step.start" in event_types
         assert "forward_model_step.success" in event_types
+        assert False