Fix smoother_update runmodels not using active realizations

This commit fixes the issue where all the run models using smoother_update would ignore the specified active realizations.

(cherry picked from commit f361ca3)

Author: jonathan-eq

src/ert/analysis/_es_update.py

@@ -419,13 +419,16 @@ def smoother_update(
     rng: np.random.Generator | None = None,
     progress_callback: Callable[[AnalysisEvent], None] | None = None,
     global_scaling: float = 1.0,
+    active_realizations: list[bool] | None = None,
 ) -> SmootherSnapshot:
     if not progress_callback:
         progress_callback = noop_progress_callback
     if rng is None:
         rng = np.random.default_rng()
 
     ens_mask = prior_storage.get_realization_mask_with_responses()
+    if active_realizations:
+        ens_mask &= active_realizations
 
     smoother_snapshot = SmootherSnapshot(
         source_ensemble_name=prior_storage.name,

src/ert/run_models/ensemble_smoother.py

@@ -78,6 +78,7 @@ def update_ensemble_parameters(
                 prior.iteration,
                 prior.id,
             ),
+            active_realizations=self.active_realizations,
         )
 
     @classmethod

src/ert/run_models/manual_update.py

@@ -59,6 +59,7 @@ def update_ensemble_parameters(
                 prior.iteration,
                 prior.id,
             ),
+            active_realizations=self.active_realizations,
         )
 
     @classmethod

src/ert/run_models/multiple_data_assimilation.py

@@ -143,6 +143,7 @@ def update_ensemble_parameters(
                 prior.iteration,
                 prior.id,
             ),
+            active_realizations=self.active_realizations,
         )
 
     @staticmethod

tests/ert/unit_tests/analysis/test_es_update.py

@@ -1175,6 +1175,8 @@ def test_gen_data_missing(storage, uniform_parameter, obs):
 
 @pytest.mark.usefixtures("use_tmpdir")
 def test_update_subset_parameters(storage, uniform_parameter, obs):
+    ensemble_size = 12  # We only want to update 0-9
+    active_realizations = [True] * 10 + [False] * 2
     no_update_param = GenKwConfig(
         name="EXTRA_PARAMETER",
         forward_init=False,
@@ -1193,7 +1195,7 @@ def test_update_subset_parameters(storage, uniform_parameter, obs):
     )
     prior = storage.create_ensemble(
         experiment,
-        ensemble_size=10,
+        ensemble_size=ensemble_size,
         iteration=0,
         name="prior",
     )
@@ -1248,6 +1250,7 @@ def test_update_subset_parameters(storage, uniform_parameter, obs):
         ["PARAMETER"],
         ObservationSettings(),
         ESSettings(),
+        active_realizations=active_realizations,
     )
 
     assert (
@@ -1258,3 +1261,8 @@ def test_update_subset_parameters(storage, uniform_parameter, obs):
         prior.load_parameters("PARAMETER", 0).rows()
         != posterior_ens.load_parameters("PARAMETER", 0).rows()
     )
+    assert prior.ensemble_size == posterior_ens.ensemble_size
+    assert len(prior.load_parameters("PARAMETER")["realization"]) == ensemble_size
+    assert len(
+        posterior_ens.load_parameters("PARAMETER")["realization"]
+    ) == active_realizations.count(True)