ToSquash: format errors nicely

Author: SAKavli

src/ert/observation_converters/summary_to_yaml.py

@@ -6,7 +6,7 @@
 from ruamel.yaml import YAML
 
 from ert.cli.main import ErtCliError
-from ert.config import ErtConfig, Observation
+from ert.config import ConfigValidationError, ErtConfig, Observation
 from ert.plugins import ErtRuntimePlugins
 
 
@@ -79,7 +79,12 @@ def export_yaml(self) -> None:
 def convert_summary_to_yaml(config: str, site_plugins: ErtRuntimePlugins) -> None:
     with warnings.catch_warnings():
         warnings.filterwarnings(action="ignore")
-        ert_config = ErtConfig.with_plugins(site_plugins).from_file(config)
+        try:
+            ert_config = ErtConfig.with_plugins(site_plugins).from_file(config)
+        except ConfigValidationError as e:
+            raise ErtCliError(
+                f"Failed to internalize the ert config '{config}' with error:\n    {e}"
+            ) from e
 
     observations = ert_config.observation_declarations
 

tests/ert/unit_tests/cli/test_summary_to_yaml.py

@@ -276,3 +276,23 @@ def test_that_relative_min_error_is_unchanged_after_conversion_given_error_min_k
         error_mode=ErrorModes.RELMIN, error_min=error_min
     )
     assert error == error_min
+
+
+def test_that_errors_are_formatted_to_user_with_message(use_tmpdir):
+    obs_config = "foo"
+    summary_obs = "SUMMARY_OBSERVATION { This is not a valid observation };"
+    Path(obs_config).write_text(
+        summary_obs,
+        encoding="utf-8",
+    )
+
+    ert_config = "config.ert"
+    minimal_ert_config = f"""\
+    NUM_REALIZATIONS 10
+    ECLBASE foo
+    OBS_CONFIG {obs_config}
+    """
+    Path(ert_config).write_text(minimal_ert_config, encoding="utf-8")
+    args = MagicMock(format="yaml", config=ert_config)
+    with pytest.raises(ErtCliError, match="Failed to internalize the ert config"):
+        convert_observations(args, ErtRuntimePlugins())