ToSquash: Add tests for error modes

Author: SAKavli

tests/ert/unit_tests/cli/test_summary_to_yaml.py

@@ -4,10 +4,12 @@
 from textwrap import dedent
 from unittest.mock import MagicMock
 
+import numpy as np
 import pytest
+from ruamel.yaml import YAML
 
 from ert.cli.main import ErtCliError
-from ert.config._observations import SummaryObservation
+from ert.config._observations import ErrorModes, SummaryObservation
 from ert.observation_converters import convert_observations
 from ert.observation_converters.summary_to_yaml import YamlConverter
 from ert.plugins import ErtRuntimePlugins
@@ -209,3 +211,68 @@ def test_that_yaml_converter_retains_time_precision_when_present():
         minute_precision,
         hour_precision,
     ]
+
+
+_VALUE = 10
+_ERROR = 5
+
+
+def _setup_and_convert_with_error_mode_config(
+    error_mode: ErrorModes, error_min=None
+) -> int | float:
+    config = "config.ert"
+    obs_config = "obs.txt"
+
+    config_content = f"""\
+        NUM_REALIZATIONS 5
+        ECLBASE FOO
+        OBS_CONFIG {obs_config}
+        """
+    error_min_line = f"ERROR_MIN={error_min};" if error_min is not None else ""
+    obs_config_content = f"""\
+        SUMMARY_OBSERVATION {{
+            KEY=FOPR;
+            VALUE={_VALUE};
+            ERROR={_ERROR};
+            ERROR_MODE={error_mode};
+            DATE=2010-10-10;
+            {error_min_line}
+        }};"""
+    Path(config).write_text(config_content, encoding="utf-8")
+    Path(obs_config).write_text(obs_config_content, encoding="utf-8")
+
+    args = MagicMock(format="yaml", config=config)
+    convert_observations(args, ErtRuntimePlugins())
+
+    yaml = YAML()
+    with Path.open(YamlConverter.TARGET_FILE) as f:
+        yaml_output = yaml.load(f)
+
+    return yaml_output["smry"][0]["observations"][0]["error"]
+
+
+def test_that_absolute_error_is_unchanged_after_conversion(use_tmpdir):
+    error = _setup_and_convert_with_error_mode_config(error_mode=ErrorModes.ABS)
+    assert error == _ERROR
+
+
+def test_that_relative_error_is_product_of_val_and_error_after_conversion(use_tmpdir):
+    error = _setup_and_convert_with_error_mode_config(error_mode=ErrorModes.REL)
+    assert error == _ERROR * _VALUE
+
+
+def test_that_rel_min_error_is_product_of_val_and_err_after_conversion_given_no_err_min(
+    use_tmpdir,
+):
+    error = _setup_and_convert_with_error_mode_config(error_mode=ErrorModes.RELMIN)
+    assert error == _ERROR * _VALUE
+
+
+def test_that_relative_min_error_is_unchanged_after_conversion_given_error_min_key(
+    use_tmpdir,
+):
+    error_min = np.inf
+    error = _setup_and_convert_with_error_mode_config(
+        error_mode=ErrorModes.RELMIN, error_min=error_min
+    )
+    assert error == error_min