Add simple statistics interface

The statistics customization tab disappeared with the plot
customization dialog, leaving no way to choose which statistics to
show. Reintroduce the controls in the plot sidebar.

Author: MagnusSletten

src/ert/gui/plotting/plot_window.py

@@ -62,8 +62,10 @@
 from .widgets.everest_control_selection_widget import EverestControlSelectionWidget
 from .widgets.plot_controls import (
     BoxplotOptions,
+    DistributionOptions,
     EverestControlsPlotOptions,
     GeneralPlotOptions,
+    StatisticsOptions,
 )
 from .widgets.plot_ensemble_selection_widget import EnsembleSelectionWidget
 from .widgets.plot_widget import Plotter, PlotWidget
@@ -300,6 +302,8 @@ def __init__(
             self._general_options.axisLabelEditRequested.connect(self._edit_axis_label)
             self._general_options.titleEditRequested.connect(self._edit_title)
             self._boxplot_options = BoxplotOptions(self.update_plot)
+            self._statistics_options = StatisticsOptions(self.update_plot)
+            self._distribution_options = DistributionOptions(self.update_plot)
 
             right_container = QWidget()
             right_layout = create_group_layout(
@@ -309,13 +313,17 @@ def __init__(
                     self._everest_controls_plot_options.get_widget(),
                     self._everest_controls_group,
                     self._boxplot_options.get_widget(),
+                    self._statistics_options.get_widget(),
+                    self._distribution_options.get_widget(),
                 ]
             )
             right_container.setLayout(right_layout)
 
             self._everest_controls_group.setVisible(False)
             self._everest_controls_plot_options.get_widget().setVisible(False)
             self._boxplot_options.get_widget().setVisible(False)
+            self._statistics_options.get_widget().setVisible(False)
+            self._distribution_options.get_widget().setVisible(False)
             self._data_type_keys_widget.selectDefault()
 
             splitter = QSplitter(Qt.Orientation.Horizontal)
@@ -383,6 +391,10 @@ def update_plot(self, layer: int | None = None) -> None:
         self._boxplot_options.get_widget().setVisible(
             plot_widget.name in {MISFITS, CROSS_ENSEMBLE_STATISTICS}
         )
+        self._statistics_options.get_widget().setVisible(plot_widget.name == STATISTICS)
+        self._distribution_options.get_widget().setVisible(
+            plot_widget.name == DISTRIBUTION
+        )
         self._general_options.get_widget().setVisible(plot_widget.name != STD_DEV)
 
         is_gradient_plot = plot_widget.name == EVEREST_GRADIENTS_PLOT
@@ -538,13 +550,12 @@ def fetch_data(
                     handle_exception(e)
 
             plot_config = PlotConfig(title=key_def.key)
-            if selected_tab == STATISTICS:
-                plot_config.set_statistics_styles_for_dimensionality(
-                    key_def.dimensionality
-                )
             plot_config.set_title(self._titles.get(key_def.key, key_def.key))
             plot_config.set_x_label(self._x_labels.get(key_def.key))
             plot_config.set_y_label(self._y_labels.get(key_def.key))
+            self._statistics_options.set_dimensionality(key_def.dimensionality)
+            self._statistics_options.apply_to(plot_config)
+            self._distribution_options.apply_to(plot_config)
             plot_config.set_legend_enabled(self._general_options.legend_checkbox_state)
             plot_config.set_grid_enabled(self._general_options.grid_checkbox_state)
             plot_config.set_line_color_cycle(self._general_options.get_color_cycle())

src/ert/gui/plotting/utils/plot_config.py

@@ -5,6 +5,12 @@
 
 from .plot_color_palettes import TABLEAU_10_COLOR_CYCLE
 from .plot_style import PlotStyle
+from .statistics_style import (
+    BAND_AREA_STYLE,
+    BAND_STATISTICS,
+    STATISTIC_LABELS,
+    STATISTICS_STYLE_PRESETS,
+)
 
 
 class PlotConfig:
@@ -63,12 +69,8 @@ def __init__(
         self._grid_enabled = True
 
         self._statistics_style = {
-            "mean": PlotStyle("Mean", line_style=""),
-            "p50": PlotStyle("P50", line_style=""),
-            "min-max": PlotStyle("Min/Max", line_style=""),
-            "p10-p90": PlotStyle("P10-P90", line_style=""),
-            "p33-p67": PlotStyle("P33-P67", line_style=""),
-            "std": PlotStyle("Std dev", line_style=""),
+            statistic: PlotStyle(label, line_style="")
+            for statistic, label in STATISTIC_LABELS.items()
         }
 
         self._std_dev_factor = 1  # sigma 1 is default std dev
@@ -77,25 +79,27 @@ def __init__(
         self.flip_observation_axis = False
 
     def set_statistics_styles_for_dimensionality(self, dimensionality: int) -> None:
-        mean_style = self._statistics_style["mean"]
-        p10p90_style = self._statistics_style["p10-p90"]
-        std_style = self._statistics_style["std"]
-
-        mean_style.line_style = ""
-        mean_style.marker = ""
-        p10p90_style.line_style = ""
-        p10p90_style.marker = ""
-        std_style.line_style = ""
-        std_style.marker = ""
-
-        if dimensionality == 2:
-            mean_style.line_style = "-"
-            p10p90_style.line_style = "--"
-        elif dimensionality == 1:
-            mean_style.line_style = "-"
-            mean_style.marker = "o"
-            std_style.line_style = "--"
-            std_style.marker = "D"
+        preset = STATISTICS_STYLE_PRESETS.get(dimensionality, {})
+        for statistic, style in self._statistics_style.items():
+            style.line_style, style.marker = preset.get(statistic, ("", ""))
+
+    def set_statistics_options(
+        self,
+        dimensionality: int,
+        enabled_statistics: set[str],
+        *,
+        fill_bands: bool,
+    ) -> None:
+        """Apply the user's selections on top of the dimensionality styles."""
+        self.set_statistics_styles_for_dimensionality(dimensionality)
+
+        for statistic, style in self._statistics_style.items():
+            if statistic not in enabled_statistics:
+                style.line_style = ""
+                style.marker = ""
+            elif fill_bands and dimensionality == 2 and statistic in BAND_STATISTICS:
+                style.line_style = BAND_AREA_STYLE
+                style.marker = ""
 
     def get_number_of_colors(self) -> int:
         return len(self._line_color_cycle_colors)

src/ert/gui/plotting/utils/qt_creator.py

@@ -5,7 +5,10 @@
 from PyQt6.QtWidgets import (
     QCheckBox,
     QGroupBox,
+    QHBoxLayout,
     QLabel,
+    QSpinBox,
+    QToolButton,
     QVBoxLayout,
     QWidget,
 )
@@ -42,6 +45,44 @@ def create_group_box(title: str, layout: QVBoxLayout) -> QGroupBox:
     return group_box
 
 
+def create_collapsible_group_box(
+    title: str, layout: QVBoxLayout, name: str, *, expanded: bool = True
+) -> QGroupBox:
+    """Create a group box whose contents can be folded away by its header.
+
+    Collapsing only hides the contents; the widgets keep their values.
+    """
+    content = QWidget()
+    content.setObjectName(f"{name}_content")
+    content.setLayout(layout)
+    content.setVisible(expanded)
+
+    header = QToolButton()
+    header.setObjectName(f"{name}_header")
+    header.setText(title)
+    header.setCheckable(True)
+    header.setChecked(expanded)
+    header.setAutoRaise(True)
+    header.setToolButtonStyle(Qt.ToolButtonStyle.ToolButtonTextBesideIcon)
+    header.setArrowType(Qt.ArrowType.DownArrow if expanded else Qt.ArrowType.RightArrow)
+    header.setStyleSheet("QToolButton { border: none; font-style: italic; }")
+
+    def toggle_contents(checked: bool) -> None:
+        header.setArrowType(
+            Qt.ArrowType.DownArrow if checked else Qt.ArrowType.RightArrow
+        )
+        content.setVisible(checked)
+
+    header.toggled.connect(toggle_contents)
+
+    outer_layout = QVBoxLayout()
+    outer_layout.setContentsMargins(0, 0, 0, 0)
+    outer_layout.addWidget(header)
+    outer_layout.addWidget(content)
+
+    return create_group_box("", outer_layout)
+
+
 def create_checkbox_with_tooltip(
     name: str,
     tooltip: str,
@@ -57,3 +98,33 @@ def create_checkbox_with_tooltip(
     checkbox.stateChanged.connect(connection_point)
     log_plot_option_usage_once(checkbox.clicked, logger, name)
     return checkbox
+
+
+def create_spinbox_with_tooltip(
+    name: str,
+    tooltip: str,
+    connection_point: Callable[..., object],
+    *,
+    minimum: int,
+    maximum: int,
+    initial_value: int,
+    logger: Logger,
+) -> QSpinBox:
+    spinbox = QSpinBox()
+    spinbox.setObjectName(f"{name.lower().replace(' ', '_')}_spinbox")
+    spinbox.setToolTip(tooltip)
+    spinbox.setRange(minimum, maximum)
+    spinbox.setValue(initial_value)
+    spinbox.valueChanged.connect(connection_point)
+    log_plot_option_usage_once(spinbox.valueChanged, logger, name)
+    return spinbox
+
+
+def create_labeled_row(label: str, widget: QWidget) -> QWidget:
+    row = QWidget()
+    layout = QHBoxLayout(row)
+    layout.setContentsMargins(0, 0, 0, 0)
+    layout.addWidget(QLabel(label))
+    layout.addWidget(widget)
+    layout.addStretch()
+    return row

src/ert/gui/plotting/widgets/plot_controls/__init__.py

@@ -1,13 +1,17 @@
 from .boxplot_options import BoxplotOptions
 from .custom_palette_dialog import CustomPaletteDialog
+from .distribution_options import DistributionOptions
 from .everest_controls_plot_options import EverestControlsPlotOptions
 from .general_options import GeneralPlotOptions
 from .plot_color_palette_selector import PlotColorPaletteSelector
+from .statistics_options import StatisticsOptions
 
 __all__ = [
     "BoxplotOptions",
     "CustomPaletteDialog",
+    "DistributionOptions",
     "EverestControlsPlotOptions",
     "GeneralPlotOptions",
     "PlotColorPaletteSelector",
+    "StatisticsOptions",
 ]

src/ert/gui/plotting/widgets/plot_controls/distribution_options.py

@@ -0,0 +1,42 @@
+from __future__ import annotations
+
+import logging
+from collections.abc import Callable
+from typing import TYPE_CHECKING
+
+from PyQt6.QtWidgets import QGroupBox
+
+from ert.gui.plotting.utils.qt_creator import (
+    create_checkbox_with_tooltip,
+    create_group_box,
+    create_group_layout,
+)
+
+if TYPE_CHECKING:
+    from ert.gui.plotting.utils import PlotConfig
+
+logger = logging.getLogger(__name__)
+
+
+class DistributionOptions:
+    def __init__(self, connection_point: Callable[..., object]) -> None:
+        self._connection_lines_toggle = create_checkbox_with_tooltip(
+            "Connection lines",
+            "Draw lines between the realizations of neighbouring ensembles",
+            connection_point,
+            initial_checked=False,
+            logger=logger,
+        )
+
+        self._distribution_options = create_group_box(
+            "Distribution options",
+            create_group_layout([self._connection_lines_toggle]),
+        )
+
+    def apply_to(self, plot_config: PlotConfig) -> None:
+        plot_config.set_distribution_line_enabled(
+            self._connection_lines_toggle.isChecked()
+        )
+
+    def get_widget(self) -> QGroupBox:
+        return self._distribution_options