Fix tasks already being completed upon scheduling

Eddasol · Eddasol · commit 19ab78ba0a78 · 2025-03-11T09:30:33.000+01:00
diff --git a/backend/api/Controllers/MissionSchedulingController.cs b/backend/api/Controllers/MissionSchedulingController.cs
@@ -71,7 +71,7 @@ [FromBody] ScheduleMissionQuery scheduledMissionQuery
                         t.Status != Database.Models.TaskStatus.Successful
                         && t.Status != Database.Models.TaskStatus.PartiallySuccessful
                 )
-                .Select((t) => new MissionTask(t, Database.Models.TaskStatus.NotStarted))
+                .Select((t) => new MissionTask(t))
                 .ToList();
 
             if (missionTasks == null || missionTasks.Count == 0)
diff --git a/backend/api/Database/Models/MissionTask.cs b/backend/api/Database/Models/MissionTask.cs
@@ -89,7 +89,7 @@ public MissionTask(Pose robotPose, MissionTaskType type)
         }
 
         // Creates a copy of the provided task
-        public MissionTask(MissionTask copy, TaskStatus? status = null)
+        public MissionTask(MissionTask copy)
         {
             TaskOrder = copy.TaskOrder;
             TagId = copy.TagId;
@@ -98,7 +98,7 @@ public MissionTask(MissionTask copy, TaskStatus? status = null)
             TagLink = copy.TagLink;
             RobotPose = new Pose(copy.RobotPose);
             PoseId = copy.PoseId;
-            Status = status ?? copy.Status;
+            Status = TaskStatus.NotStarted;
             IsarZoomDescription = copy.IsarZoomDescription;
             if (copy.Inspection is not null)
             {

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ [FromBody] ScheduleMissionQuery scheduledMissionQuery`
`71`	`71`	`t.Status != Database.Models.TaskStatus.Successful`
`72`	`72`	`&& t.Status != Database.Models.TaskStatus.PartiallySuccessful`
`73`	`73`	`)`
`74`		`- .Select((t) => new MissionTask(t, Database.Models.TaskStatus.NotStarted))`
	`74`	`+ .Select((t) => new MissionTask(t))`
`75`	`75`	`.ToList();`
`76`	`76`
`77`	`77`	`if (missionTasks == null \|\| missionTasks.Count == 0)`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public MissionTask(Pose robotPose, MissionTaskType type)`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`// Creates a copy of the provided task`
`92`		`- public MissionTask(MissionTask copy, TaskStatus? status = null)`
	`92`	`+ public MissionTask(MissionTask copy)`
`93`	`93`	`{`
`94`	`94`	`TaskOrder = copy.TaskOrder;`
`95`	`95`	`TagId = copy.TagId;`
`@@ -98,7 +98,7 @@ public MissionTask(MissionTask copy, TaskStatus? status = null)`
`98`	`98`	`TagLink = copy.TagLink;`
`99`	`99`	`RobotPose = new Pose(copy.RobotPose);`
`100`	`100`	`PoseId = copy.PoseId;`
`101`		`- Status = status ?? copy.Status;`
	`101`	`+ Status = TaskStatus.NotStarted;`
`102`	`102`	`IsarZoomDescription = copy.IsarZoomDescription;`
`103`	`103`	`if (copy.Inspection is not null)`
`104`	`104`	`{`