Skip to content

Commit 40f2fa5

Browse files
committed
Do not send mission deprecated to frontend
1 parent 8dae561 commit 40f2fa5

5 files changed

Lines changed: 2 additions & 15 deletions

File tree

backend/api/Controllers/Models/MissionDefinitionResponse.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ public class MissionDefinitionResponse
1313
public AutoScheduleFrequency? AutoScheduleFrequency { get; set; }
1414
public virtual MissionRun? LastSuccessfulRun { get; set; }
1515
public InspectionAreaResponse InspectionArea { get; set; }
16-
public bool IsDeprecated { get; set; }
1716

1817
[JsonConstructor]
1918
#nullable disable
@@ -37,7 +36,6 @@ missionDefinition.AutoScheduleFrequency is not null
3736
: null;
3837
LastSuccessfulRun = missionDefinition.LastSuccessfulRun;
3938
InspectionArea = new InspectionAreaResponse(missionDefinition.InspectionArea);
40-
IsDeprecated = missionDefinition.IsDeprecated;
4139
}
4240
}
4341
}

frontend/src/components/Dialogs/MissionEditDialog.tsx

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,9 @@ import { StyledDialog } from 'components/Styles/StyledComponents'
1313
import { allDays, DaysOfWeek, TimeAndDay } from 'models/AutoScheduleFrequency'
1414
import { MissionDefinition } from 'models/MissionDefinition'
1515
import { MissionDefinitionUpdateForm } from 'models/MissionDefinitionUpdateForm'
16-
import { ChangeEvent, useContext, useState } from 'react'
17-
import { useNavigate } from 'react-router-dom'
16+
import { ChangeEvent, useState } from 'react'
1817
import styled from 'styled-components'
1918
import { useBackendApi } from 'api/UseBackendApi'
20-
import { InstallationContext } from 'components/Contexts/InstallationContext'
2119

2220
const StyledSummary = styled.div`
2321
padding: 16px 8px 0px 8px;
@@ -57,8 +55,6 @@ const StyledTimeChips = styled.div`
5755
const useMissionUpdater = () => {
5856
const { TranslateText } = useLanguageContext()
5957
const { setAlert, setListAlert } = useAlertContext()
60-
const { installation } = useContext(InstallationContext)
61-
const navigate = useNavigate()
6258
const backendApi = useBackendApi()
6359

6460
const updateMission = (
@@ -70,16 +66,12 @@ const useMissionUpdater = () => {
7066
comment: mission.comment,
7167
schedulingTimesCETperWeek: mission.autoScheduleFrequency?.schedulingTimesCETperWeek,
7268
name: mission.name,
73-
isDeprecated: false,
7469
}
7570
const form: MissionDefinitionUpdateForm = { ...defaultForm, ...partialForm }
7671

7772
backendApi
7873
.updateMissionDefinition(mission.id, form)
79-
.then((missionDefinition) => {
80-
onSuccess()
81-
if (missionDefinition.isDeprecated) navigate(`/${installation.installationCode}`)
82-
})
74+
.then(onSuccess)
8375
.catch(() => {
8476
setAlert(
8577
AlertType.RequestFail,

frontend/src/models/MissionDefinition.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,5 @@ export interface MissionDefinition {
3838
autoScheduleFrequency?: AutoScheduleFrequency
3939
lastSuccessfulRun?: Mission
4040
inspectionArea: InspectionArea
41-
isDeprecated: boolean
4241
tasks: MissionTaskDefinition[]
4342
}

frontend/src/models/MissionDefinitionUpdateForm.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@ export interface MissionDefinitionUpdateForm {
44
comment?: string
55
schedulingTimesCETperWeek?: TimeAndDay[]
66
name?: string
7-
isDeprecated?: boolean
87
}

frontend/src/pages/MissionDefinitionPage/MissionDefinitionPage.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ const MissionDefinitionPageBody = ({ missionDefinition }: { missionDefinition: M
120120
comment: missionDefinition.comment,
121121
schedulingTimesCETperWeek: [],
122122
name: missionDefinition.name,
123-
isDeprecated: false,
124123
}
125124
backendApi.updateMissionDefinition(missionDefinition.id, defaultMissionDefinitionForm).catch(() => {
126125
setAlert(

0 commit comments

Comments
 (0)