Fix auto schedule frequency never becoming null

Author: Eddasol

backend/api/Controllers/Models/MissionDefinitionResponse.cs

@@ -87,7 +87,8 @@ MissionDefinition missionDefinition
         public TimeSpan? InspectionFrequency { get; } = missionDefinition.InspectionFrequency;
 
         [JsonPropertyName("autoScheduleFrequency")]
-        public AutoScheduleFrequency? AutoScheduleFrequency { get; set; }
+        public AutoScheduleFrequency? AutoScheduleFrequency { get; } =
+            missionDefinition.AutoScheduleFrequency;
 
         [JsonPropertyName("lastSuccessfulRun")]
         public virtual MissionRun? LastSuccessfulRun { get; } = missionDefinition.LastSuccessfulRun;

backend/api/Database/Context/FlotillaDbContext.cs

@@ -67,6 +67,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
                 .Entity<MissionDefinition>()
                 .Property(m => m.InspectionFrequency)
                 .HasConversion(new TimeSpanToTicksConverter());
+            modelBuilder.Entity<MissionDefinition>().OwnsOne(m => m.AutoScheduleFrequency);
 
             modelBuilder
                 .Entity<MissionDefinition>()

backend/api/Database/Models/AutoScheduleFrequency.cs

@@ -8,23 +8,27 @@ namespace Api.Database.Models
     [Owned]
     public class AutoScheduleFrequency
     {
-        [Required]
         // In local time
-        public IList<TimeOnly> TimesOfDay { get; set; }
+        public IList<TimeOnly>? TimesOfDay { get; set; }
 
-        [Required]
-        public IList<DayOfWeek> DaysOfWeek { get; set; }
+        public IList<DayOfWeek>? DaysOfWeek { get; set; }
 
         public void ValidateAutoScheduleFrequency()
         {
-            if (TimesOfDay.Count == 0)
+            // Either both should be null or both should be a list with at least one element
+            if (TimesOfDay is null && DaysOfWeek is null)
+            {
+                return;
+            }
+
+            if (TimesOfDay is null || TimesOfDay.Count == 0)
             {
                 throw new ArgumentException(
                     "AutoScheduleFrequency must have at least one time of day"
                 );
             }
 
-            if (DaysOfWeek.Count == 0)
+            if (DaysOfWeek is null || DaysOfWeek.Count == 0)
             {
                 throw new ArgumentException(
                     "AutoScheduleFrequency must have at least one day of week"
@@ -34,6 +38,11 @@ public void ValidateAutoScheduleFrequency()
 
         public IList<TimeSpan>? GetSchedulingTimesForNext24Hours()
         {
+            if (TimesOfDay is null || DaysOfWeek is null)
+            {
+                return null;
+            }
+
             // NCS is always in CET
             TimeZoneInfo tzi = TimeZoneInfo.FindSystemTimeZoneById(
                 "Central European Standard Time"