Skip to content

Test migration workflow: add optional Plant.Description - #2687

Closed
aeshub wants to merge 4 commits into
equinor:mainfrom
aeshub:test-migration-workflow
Closed

Test migration workflow: add optional Plant.Description#2687
aeshub wants to merge 4 commits into
equinor:mainfrom
aeshub:test-migration-workflow

Conversation

@aeshub

@aeshub aeshub commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add optional Description property to Plant database model + EF Core migration
  • Revert: remove Description property + drop-column migration

Purpose

This is a test PR to verify the new consolidated migration workflows from equinor/armada#39. The expected behavior is:

  1. verify_migrations workflow detects changes in backend/api/Database/** and backend/api/Migrations/**
  2. notify_migrations_on_pr workflow posts a reminder comment about possible missing migrations
  3. verify_migrations job blocks merge until /UpdateDatabase has been run

Test results

  • First /UpdateDatabase correctly rejected (PR not yet approved)
  • Second /UpdateDatabase after approval: successfully applied AddPlantDescription migration
  • verify_migrations passed after /UpdateDatabase succeeded
  • Notification comment posted and database-change label added

Current state

Revert migration added (RevertPlantDescription) — needs /UpdateDatabase to drop the Description column from dev DB. After that, this PR can be merged and the test column will be fully cleaned up.

@aeshub aeshub closed this Apr 28, 2026
@aeshub aeshub reopened this Apr 28, 2026
@github-actions

Copy link
Copy Markdown

🔔 Changes in database files detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@aeshub aeshub closed this Apr 28, 2026
@aeshub aeshub reopened this Apr 28, 2026
@aeshub
aeshub force-pushed the test-migration-workflow branch from 6810f79 to d483255 Compare April 28, 2026 12:55
@aeshub

aeshub commented Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

/UpdateDatabase

@github-actions

Copy link
Copy Markdown

⛔ Cannot update database until the Pull Request is approved! ⛔

@Christdej Christdej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but remember to add migrations

@aeshub

aeshub commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

/UpdateDatabase

@github-actions

Copy link
Copy Markdown

👀 Running migration command... 👀

@github-actions

Copy link
Copy Markdown

✨ Successfully ran migration command! ✨

@aeshub aeshub closed this Apr 29, 2026
@aeshub aeshub reopened this Apr 29, 2026
@github-actions

Copy link
Copy Markdown

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions Bot added the database-change Will require migration label Apr 29, 2026
@aeshub aeshub self-assigned this Apr 29, 2026
@aeshub

aeshub commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

/UpdateDatabase

@github-actions

Copy link
Copy Markdown

👀 Running migration command... 👀

@github-actions

Copy link
Copy Markdown

✨ Successfully ran migration command! ✨

@aeshub

aeshub commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Closing as the test of migrations is completed

@aeshub aeshub closed this Apr 29, 2026
@aeshub
aeshub deleted the test-migration-workflow branch April 29, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database-change Will require migration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants