Skip to content

Dedup AnalysisTypes between MissionTask and Inspection #2720

Description

@aeshub

Context

PR #2694 added AnalysisTypes to MissionTask as a drive-by alongside the wire-mapping work. The same field already exists on Inspection, which is the source of truth used by IsarMissionDefinition.ToSaraAnalysisKeys.

Problem

The two AnalysisTypes collections can drift. MissionTask.AnalysisTypes is currently populated from TaskDefinition.ToMissionRunTask() but is not the wire source — Inspection.AnalysisTypes is.

Proposal

Pick one source of truth and remove the other:

  • Option A — Drop MissionTask.AnalysisTypes; keep only Inspection.AnalysisTypes.
  • Option B — Promote MissionTask.AnalysisTypes as the source; remove from Inspection.

Option A is preferred since the wire mapper already reads from Inspection.

Related

Metadata

Metadata

Assignees

Labels

improvementImprovement to existing functionality

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions