Context
PR #2694 added AnalysisTypes to MissionTask as a drive-by alongside the wire-mapping work. The same field already exists on Inspection, which is the source of truth used by IsarMissionDefinition.ToSaraAnalysisKeys.
Problem
The two AnalysisTypes collections can drift. MissionTask.AnalysisTypes is currently populated from TaskDefinition.ToMissionRunTask() but is not the wire source — Inspection.AnalysisTypes is.
Proposal
Pick one source of truth and remove the other:
- Option A — Drop
MissionTask.AnalysisTypes; keep only Inspection.AnalysisTypes.
- Option B — Promote
MissionTask.AnalysisTypes as the source; remove from Inspection.
Option A is preferred since the wire mapper already reads from Inspection.
Related
Context
PR #2694 added
AnalysisTypestoMissionTaskas a drive-by alongside the wire-mapping work. The same field already exists onInspection, which is the source of truth used byIsarMissionDefinition.ToSaraAnalysisKeys.Problem
The two
AnalysisTypescollections can drift.MissionTask.AnalysisTypesis currently populated fromTaskDefinition.ToMissionRunTask()but is not the wire source —Inspection.AnalysisTypesis.Proposal
Pick one source of truth and remove the other:
MissionTask.AnalysisTypes; keep onlyInspection.AnalysisTypes.MissionTask.AnalysisTypesas the source; remove fromInspection.Option A is preferred since the wire mapper already reads from
Inspection.Related