diff --git a/.github/workflows/validate_dotnet_migrations_against_temp_db.yml b/.github/workflows/validate_dotnet_migrations_against_temp_db.yml index 3164e4fb8..2c41321a2 100644 --- a/.github/workflows/validate_dotnet_migrations_against_temp_db.yml +++ b/.github/workflows/validate_dotnet_migrations_against_temp_db.yml @@ -6,6 +6,9 @@ on: - 'backend/api/**' - '.github/workflows/**' +permissions: + contents: read + jobs: validate_dotnet_migrations_against_temp_db: uses: equinor/armada/.github/workflows/validate_dotnet_migrations_against_temp_db.yml@main diff --git a/backend/api/Services/AreaPolygonService.cs b/backend/api/Services/AreaPolygonService.cs index fa72f4d58..111e8d8b4 100644 --- a/backend/api/Services/AreaPolygonService.cs +++ b/backend/api/Services/AreaPolygonService.cs @@ -1,4 +1,5 @@ using Api.Database.Models; +using Api.Utilities; namespace Api.Services { @@ -40,9 +41,11 @@ public bool MissionTasksAreInsideAreaPolygon( ) { logger.LogWarning( - "Robot position {robotPosition} is outside the inspection area polygon for task {taskId}", - robotPosition, - missionTask.Id + "Robot position (X={X}, Y={Y}, Z={Z}) is outside the inspection area polygon for task {taskId}", + robotPosition.X, + robotPosition.Y, + robotPosition.Z, + Sanitize.SanitizeUserInput(missionTask.Id) ); return false; } diff --git a/backend/api/Utilities/SanitizeInput.cs b/backend/api/Utilities/SanitizeInput.cs index 0eb359625..b371c56a1 100644 --- a/backend/api/Utilities/SanitizeInput.cs +++ b/backend/api/Utilities/SanitizeInput.cs @@ -5,9 +5,9 @@ namespace Api.Utilities { public static class Sanitize { - public static string SanitizeUserInput(string inputString) + public static string SanitizeUserInput(string? inputString) { - return inputString.Replace("\n", "").Replace("\r", ""); + return inputString?.Replace("\n", "").Replace("\r", "") ?? string.Empty; } public static ScheduleMissionQuery SanitizeUserInput(ScheduleMissionQuery inputQuery)