DEP: Deprecate casepath from argument use SUMO_CASEPATH instead - #1813
Open
tnatt wants to merge 1 commit into
Open
DEP: Deprecate casepath from argument use SUMO_CASEPATH instead#1813tnatt wants to merge 1 commit into
tnatt wants to merge 1 commit into
Conversation
tnatt
force-pushed
the
make-create-case-metadata-argument-free
branch
2 times, most recently
from
August 17, 2026 08:32
2383576 to
fded6ea
Compare
tnatt
marked this pull request as ready for review
August 17, 2026 08:32
tnatt
force-pushed
the
make-create-case-metadata-argument-free
branch
from
August 17, 2026 09:00
fded6ea to
f3de07c
Compare
tnatt
force-pushed
the
make-create-case-metadata-argument-free
branch
from
August 19, 2026 13:31
f3de07c to
41950b5
Compare
tnatt
commented
Aug 19, 2026
| def casename(self) -> str: | ||
| return self.casepath.name | ||
|
|
||
| def validate(self) -> None: |
Collaborator
Author
There was a problem hiding this comment.
Moved the validation of the casepath to this new _resolve_casepath so that we minimize the risk of copying .fmu to an incorrect location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1812
PR to start prioritizing the
<SUMO_CASEPATH>variable as thecasepathforWF_CREATE_CASE_METADATAif present.<SUMO_CASEPATH>is required by theSUMO_UPLOADforward model, so it can reasonably be assumed to be defined for cases that upload assets to Sumo. The workflow now prioritizes this variable over the legacycasepathargument.The logic is:
1. If
<SUMO_CASEPATH>is defined:<SUMO_CASEPATH>as the case path.casepathargument was provided inform that the argument input is ignored and can safely be removed.2. If
<SUMO_CASEPATH>is not defined:--sumois set, raise an error instructing the user to define<SUMO_CASEPATH>in the ERT configuration.casepathargument.3. If neither
<SUMO_CASEPATH>orcasepathargument can be resolved:<SUMO_CASEPATH>must be defined.Note
I did not include an update to the main documentation now, since we are expecting some traffic of people following the getting started guide. I'll make a PR to update the documentation that we can merge once this change goes to komodo stable.
Checklist
--cov=src/ --cov-report term-missing)