MAINT: Address comments

Author: GibranAlfa

src/fmu_settings_api/v1/routes/project.py

@@ -120,8 +120,9 @@
         [
             {
                 "detail": (
-                    "Initialize the .fmu directory from a project root "
-                    f"containing {REQUIRED_PROJECT_DIRS_TEXT}."
+                    "Failed initializing .fmu directory. Initialize it from a "
+                    f"project root containing {REQUIRED_PROJECT_DIRS_TEXT}. "
+                    "Did not find: {missing_project_dirs}."
                 ),
             },
         ],

tests/conftest.py

@@ -274,13 +274,11 @@ async def client_with_session(session_id: str) -> AsyncGenerator[TestClient]:
 
 
 @pytest.fixture
-async def client_with_project_session(
-    session_id: str, make_fmu_project_root: Callable[[Path], Path]
-) -> AsyncGenerator[TestClient]:
+async def client_with_project_session(session_id: str) -> AsyncGenerator[TestClient]:
     """Returns a test client with a valid session."""
     session = await get_session(session_id)
 
-    path = make_fmu_project_root(session.user_fmu_directory.path.parent.parent)
+    path = session.user_fmu_directory.path.parent.parent  # tmp_path
     fmu_dir = init_fmu_directory(path)
     _ = await add_fmu_project_to_session(session_id, fmu_dir)
 
@@ -290,13 +288,11 @@ async def client_with_project_session(
 
 
 @pytest.fixture
-async def client_with_smda_session(
-    session_id: str, make_fmu_project_root: Callable[[Path], Path]
-) -> AsyncGenerator[TestClient]:
+async def client_with_smda_session(session_id: str) -> AsyncGenerator[TestClient]:
     """Returns a test client with a valid session."""
     session = await get_session(session_id)
 
-    path = make_fmu_project_root(session.user_fmu_directory.path.parent.parent)
+    path = session.user_fmu_directory.path.parent.parent  # tmp_path
     fmu_dir = init_fmu_directory(path)
     _ = await add_fmu_project_to_session(session_id, fmu_dir)
 
@@ -312,9 +308,9 @@ async def client_with_smda_session(
 
 
 @pytest.fixture
-def session_tmp_path(make_fmu_project_root: Callable[[Path], Path]) -> Path:
+def session_tmp_path() -> Path:
     """Returns the tmp_path equivalent from a mocked user .fmu dir."""
-    return make_fmu_project_root(UserFMUDirectory().path.parent.parent)
+    return UserFMUDirectory().path.parent.parent
 
 
 @pytest.fixture

tests/test_v1/test_project.py

@@ -838,7 +838,9 @@ async def test_post_init_fmu_directory_invalid_project_root(
     response = client_with_session.post(f"{ROUTE}/init", json={"path": str(path)})
     assert response.status_code == status.HTTP_422_UNPROCESSABLE_CONTENT
     detail = response.json()["detail"]
+    assert detail.startswith("Failed initializing .fmu directory.")
     assert "project root containing" in detail
+    assert "Did not find:" in detail
     for dir_name in REQUIRED_FMU_PROJECT_SUBDIRS:
         assert f"'{dir_name}'" in detail