BUG: Fix project lock release semantics

Author: GibranAlfa

src/fmu_settings_api/services/session.py

@@ -94,10 +94,13 @@ async def acquire_project_lock(self) -> bool:
 
     async def release_project_lock(self) -> bool:
         """Attempt to release the project lock for this session."""
+        project_session = cast("ProjectSession", self._session)
+        was_acquired = project_session.project_fmu_directory._lock.is_acquired()
+
         updated_session = await release_project_lock(self._session.id)
         lock = updated_session.project_fmu_directory._lock
 
-        return not lock.is_acquired()
+        return was_acquired and not lock.is_acquired()
 
     def get_lock_status(self) -> LockStatus:
         """Get the lock status including session-specific error information."""

tests/test_v1/test_project.py

@@ -2290,43 +2290,48 @@ async def test_post_lock_acquire_unexpected_error(
 
 async def test_post_lock_release_success(
     client_with_project_session: TestClient,
+    session_id: str,
 ) -> None:
     """Test lock release route returns success when lock is released."""
-    with patch(
-        "fmu_settings_api.services.session.SessionService.release_project_lock",
-        AsyncMock(return_value=True),
-    ):
-        response = client_with_project_session.post(f"{ROUTE}/lock_release")
+    from fmu_settings_api.session import session_manager  # noqa: PLC0415
+
+    session = await session_manager.get_session(session_id)
+    assert isinstance(session, ProjectSession)
+    assert session.project_fmu_directory._lock.is_acquired() is True
+
+    response = client_with_project_session.post(f"{ROUTE}/lock_release")
 
     assert response.status_code == status.HTTP_200_OK
     assert response.json() == {"message": "Project lock released."}
+    updated_session = await session_manager.get_session(session_id)
+    assert isinstance(updated_session, ProjectSession)
+    assert updated_session.project_fmu_directory._lock.is_acquired() is False
 
 
 async def test_post_lock_release_when_not_held(
     client_with_project_session: TestClient,
+    session_id: str,
 ) -> None:
     """Test lock release route when lock is not currently held."""
-    with (
-        patch(
-            "fmu_settings_api.services.session.SessionService.release_project_lock",
-            AsyncMock(return_value=False),
-        ),
-        patch(
-            "fmu_settings_api.services.session.SessionService.get_lock_status",
-            return_value=LockStatus(
-                is_lock_acquired=False,
-                lock_file_exists=False,
-                last_lock_release_error=None,
-            ),
-        ),
-    ):
-        response = client_with_project_session.post(f"{ROUTE}/lock_release")
+    from fmu_settings_api.session import session_manager  # noqa: PLC0415
+
+    session = await session_manager.get_session(session_id)
+    assert isinstance(session, ProjectSession)
+    session.project_fmu_directory._lock.release()
+    session.lock_errors.release = None
+    assert session.project_fmu_directory._lock.is_acquired() is False
+
+    response = client_with_project_session.post(f"{ROUTE}/lock_release")
 
     assert response.status_code == status.HTTP_200_OK
     assert response.json() == {
         "message": "Lock was not released because the lock is not currently held."
     }
 
+    updated_session = await session_manager.get_session(session_id)
+    assert isinstance(updated_session, ProjectSession)
+    assert updated_session.project_fmu_directory._lock.is_acquired() is False
+
 
 async def test_post_lock_release_records_release_error(
     client_with_project_session: TestClient,