Skip to content

Commit 5a3fa39

Browse files
committed
ENH: Use Masterdata model from fmu-datamodels
1 parent a2c0d26 commit 5a3fa39

4 files changed

Lines changed: 8 additions & 110 deletions

File tree

src/fmu/settings/models/project_config.py

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,12 @@
55
from typing import Self
66
from uuid import UUID # noqa TC003
77

8-
from pydantic import AwareDatetime, BaseModel, Field
8+
from pydantic import AwareDatetime, Field
99

10+
from fmu.datamodels.fmu_results.fields import Masterdata
1011
from fmu.settings import __version__
1112
from fmu.settings.types import ResettableBaseModel, VersionStr # noqa TC001
1213

13-
from .smda import Smda
14-
15-
16-
class Masterdata(BaseModel):
17-
"""The ``masterdata`` block contains information related to masterdata.
18-
19-
Currently, SMDA holds the masterdata.
20-
"""
21-
22-
smda: Smda | None = Field(default=None)
23-
"""Block containing SMDA-related attributes. See :class:`Smda`."""
24-
2514

2615
class ProjectConfig(ResettableBaseModel):
2716
"""The configuration file in a .fmu directory.
@@ -32,7 +21,7 @@ class ProjectConfig(ResettableBaseModel):
3221
version: VersionStr
3322
created_at: AwareDatetime
3423
created_by: str
35-
masterdata: Masterdata
24+
masterdata: Masterdata | None = Field(default=None)
3625

3726
@classmethod
3827
def reset(cls: type[Self]) -> Self:
@@ -45,5 +34,5 @@ def reset(cls: type[Self]) -> Self:
4534
version=__version__,
4635
created_at=datetime.now(UTC),
4736
created_by=getpass.getuser(),
48-
masterdata=Masterdata(),
37+
masterdata=None,
4938
)

src/fmu/settings/models/smda.py

Lines changed: 0 additions & 90 deletions
This file was deleted.

tests/conftest.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ def config_dict(unix_epoch_utc: datetime) -> dict[str, Any]:
2727
"version": __version__,
2828
"created_at": unix_epoch_utc,
2929
"created_by": "user",
30-
"masterdata": {
31-
"smda": None,
32-
},
30+
"masterdata": None,
3331
}
3432

3533

tests/test_resources/test_project_config.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
import pytest
99

10+
from fmu.datamodels.fmu_results.fields import Smda
1011
from fmu.settings._fmu_dir import ProjectFMUDirectory, UserFMUDirectory
1112
from fmu.settings.models.project_config import ProjectConfig
12-
from fmu.settings.models.smda import Smda
1313
from fmu.settings.models.user_config import UserConfig
1414
from fmu.settings.resources.config_managers import (
1515
ProjectConfigManager,
@@ -238,7 +238,7 @@ def test_set_smda(
238238
assert fmu_dir.config.get("masterdata.smda") is None
239239
with open(fmu_dir.path / fmu_dir.config.relative_path, encoding="utf-8") as f:
240240
config_on_disk = json.loads(f.read())
241-
assert config_on_disk["masterdata"]["smda"] is None
241+
assert config_on_disk["masterdata"] is None
242242

243243
fmu_dir.set_config_value("masterdata", masterdata_dict)
244244

@@ -250,6 +250,7 @@ def test_set_smda(
250250

251251
config_on_disk_model = ProjectConfig.model_validate(config_on_disk)
252252
assert fmu_dir.config._cache is not None
253+
assert fmu_dir.config._cache.masterdata is not None
253254
assert fmu_dir.config._cache.masterdata.smda == smda_model
254255
assert config_on_disk_model == fmu_dir.config._cache
255256

0 commit comments

Comments
 (0)