fix: fusion lint

Author: Noggling

packages/dev-portal/src/configure.ts

@@ -18,7 +18,7 @@ import { enableAgGrid } from '@equinor/fusion-framework-module-ag-grid';
 import { enableTelemetry } from '@equinor/fusion-framework-module-telemetry';
 import {
   enableContextNavigation,
-  enableLegacyAppNavigationFix,
+  legacyAppNavigationFix,
 } from '@equinor/fusion-framework-plugin-context-navigation';
 import {
   buildContextUrlForStrategy,
@@ -177,7 +177,7 @@ export const configure = async (config: FrameworkConfigurator) => {
 
   config.onInitialized<[AppModule, NavigationModule]>((modules) => {
     // Reset legacy app routers on context navigation for apps with navigation <v7.
-    enableLegacyAppNavigationFix({ event: modules.event });
+    legacyAppNavigationFix({ event: modules.event });
 
     // Expose framework modules globally for development debugging and inspection.
     // @ts-expect-error — `window` is not typed with `Fusion`

…s/context-navigation/src/configurator.ts …ion/src/ContextNavigationConfigurator.tspackages/plugins/context-navigation/src/configurator.ts renamed to packages/plugins/context-navigation/src/ContextNavigationConfigurator.ts packages/plugins/context-navigation/src/configurator.ts renamed to packages/plugins/context-navigation/src/ContextNavigationConfigurator.ts

@@ -2,11 +2,11 @@ import type { ContextNavigationConfig, ContextNavigationNavigatedDetail } from '
 import type { ContextNavigationAdapterInput } from './adapters/types';
 import type { ReconcilerSourceFactory } from './sources/types';
 
-import { createPathAdapter } from './adapters/path-adapter';
-import { createQueryAdapter } from './adapters/query-adapter';
+import { createPathAdapter } from './adapters/create-path-adapter';
+import { createQueryAdapter } from './adapters/create-query-adapter';
 import { createCustomAdapter } from './adapters/custom-adapter/create-custom-adapter';
-import { createResolveContextFromUrl } from './utils/resolve-context-from-url';
-import { createAppFirstSource } from './sources/app-first-source';
+import { resolveContextFromUrl } from './utils/resolve-context-from-url';
+import { appFirstSource } from './sources/app-first-source';
 
 /**
  * Resolves the default origin used for URL construction.
@@ -160,8 +160,8 @@ export class ContextNavigationConfigurator {
    * @param factory - The source factory to use for the reconciler.
    * @returns The configurator instance for chaining.
    * @see ReconcilerSourceFactory
-   * @see createAppFirstSource
-   * @see createContextFirstSource
+   * @see appFirstSource
+   * @see contextFirstSource
    */
   setSourceFactory(factory: ReconcilerSourceFactory): this {
     this.#config.sourceFactory = factory;
@@ -191,9 +191,9 @@ export class ContextNavigationConfigurator {
       nullContextUrl: this.#config.nullContextUrl,
       onTransition: this.#config.onTransition,
       navigationOptions: this.#config.navigationOptions ?? { replace: true },
-      sourceFactory: this.#config.sourceFactory ?? createAppFirstSource(),
+      sourceFactory: this.#config.sourceFactory ?? appFirstSource(),
       resolveInitialContext:
-        this.#config.resolveInitialContext ?? createResolveContextFromUrl(adapters, origin),
+        this.#config.resolveInitialContext ?? resolveContextFromUrl(adapters, origin),
       adapters,
     };
   }

packages/plugins/context-navigation/src/__tests__/active-app-navigation-events.test.ts

@@ -3,12 +3,13 @@ import { describe, expect, it } from 'vitest';
 
 import type { AppModulesInstance } from '@equinor/fusion-framework-module-app';
 import type { ContextModule } from '@equinor/fusion-framework-module-context';
-import type { ContextNavigationPluginArgs } from '../plugin';
+import type { ContextNavigationPluginArgs } from '../create-context-navigation-plugin';
 
-import { activeAppNavigationEvents$ } from '../operators/active-app-navigation-events';
+import { activeAppNavigationEvents } from '../operators/active-app-navigation-events';
 
 describe('activeAppNavigationEvents$', () => {
   it('emits when app, instance, and navigation state are all present', () => {
+    // Test double — only the context property is accessed by the operator under test
     const appModules = { context: {} } as unknown as AppModulesInstance<[ContextModule]>;
     const navigationState$ = new Subject<unknown>();
 
@@ -18,13 +19,15 @@ describe('activeAppNavigationEvents$', () => {
       manifest$: new BehaviorSubject(null),
     });
 
+    // Test double — only current$ is read by the operator under test
     const app = { current$: currentApp$ } as unknown as ContextNavigationPluginArgs['app'];
+    // Test double — only state$ is read by the operator under test
     const navigation = {
       state$: navigationState$,
     } as unknown as ContextNavigationPluginArgs['navigation'];
 
     const emissions: unknown[] = [];
-    const sub = activeAppNavigationEvents$(app, navigation).subscribe((val) => emissions.push(val));
+    const sub = activeAppNavigationEvents(app, navigation).subscribe((val) => emissions.push(val));
 
     navigationState$.next({});
 
@@ -38,13 +41,15 @@ describe('activeAppNavigationEvents$', () => {
     const navigationState$ = new Subject<unknown>();
     const currentApp$ = new BehaviorSubject(null);
 
+    // Test double — only current$ is read by the operator under test
     const app = { current$: currentApp$ } as unknown as ContextNavigationPluginArgs['app'];
+    // Test double — only state$ is read by the operator under test
     const navigation = {
       state$: navigationState$,
     } as unknown as ContextNavigationPluginArgs['navigation'];
 
     const emissions: unknown[] = [];
-    const sub = activeAppNavigationEvents$(app, navigation).subscribe((val) => emissions.push(val));
+    const sub = activeAppNavigationEvents(app, navigation).subscribe((val) => emissions.push(val));
 
     navigationState$.next({});
 
@@ -60,13 +65,15 @@ describe('activeAppNavigationEvents$', () => {
       manifest$: new BehaviorSubject(null),
     });
 
+    // Test double — only current$ is read by the operator under test
     const app = { current$: currentApp$ } as unknown as ContextNavigationPluginArgs['app'];
+    // Test double — only state$ is read by the operator under test
     const navigation = {
       state$: navigationState$,
     } as unknown as ContextNavigationPluginArgs['navigation'];
 
     const emissions: unknown[] = [];
-    const sub = activeAppNavigationEvents$(app, navigation).subscribe((val) => emissions.push(val));
+    const sub = activeAppNavigationEvents(app, navigation).subscribe((val) => emissions.push(val));
 
     navigationState$.next({});
 
@@ -75,6 +82,7 @@ describe('activeAppNavigationEvents$', () => {
   });
 
   it('re-emits on each navigation state change', () => {
+    // Test double — only the context property is accessed by the operator under test
     const appModules = { context: {} } as unknown as AppModulesInstance<[ContextModule]>;
     const navigationState$ = new Subject<unknown>();
 
@@ -84,13 +92,15 @@ describe('activeAppNavigationEvents$', () => {
       manifest$: new BehaviorSubject(null),
     });
 
+    // Test double — only current$ is read by the operator under test
     const app = { current$: currentApp$ } as unknown as ContextNavigationPluginArgs['app'];
+    // Test double — only state$ is read by the operator under test
     const navigation = {
       state$: navigationState$,
     } as unknown as ContextNavigationPluginArgs['navigation'];
 
     const emissions: unknown[] = [];
-    const sub = activeAppNavigationEvents$(app, navigation).subscribe((val) => emissions.push(val));
+    const sub = activeAppNavigationEvents(app, navigation).subscribe((val) => emissions.push(val));
 
     navigationState$.next({});
     navigationState$.next({});
@@ -101,9 +111,11 @@ describe('activeAppNavigationEvents$', () => {
   });
 
   it('switches to new app when current app changes', () => {
+    // Test double — only the context property is accessed by the operator under test
     const appModulesA = { context: { name: 'A' } } as unknown as AppModulesInstance<
       [ContextModule]
     >;
+    // Test double — only the context property is accessed by the operator under test
     const appModulesB = { context: { name: 'B' } } as unknown as AppModulesInstance<
       [ContextModule]
     >;
@@ -115,13 +127,15 @@ describe('activeAppNavigationEvents$', () => {
       manifest$: new BehaviorSubject(null),
     });
 
+    // Test double — only current$ is read by the operator under test
     const app = { current$: currentApp$ } as unknown as ContextNavigationPluginArgs['app'];
+    // Test double — only state$ is read by the operator under test
     const navigation = {
       state$: navigationState$,
     } as unknown as ContextNavigationPluginArgs['navigation'];
 
     const emissions: Array<{ appKey: string }> = [];
-    const sub = activeAppNavigationEvents$(app, navigation).subscribe((val) => emissions.push(val));
+    const sub = activeAppNavigationEvents(app, navigation).subscribe((val) => emissions.push(val));
 
     navigationState$.next({});
     expect(emissions[0]?.appKey).toBe('app-a');

packages/plugins/context-navigation/src/__tests__/apply-navigation.test.ts

@@ -12,6 +12,7 @@ import {
 import type { ContextNavigationAdapter } from '../adapters/types';
 
 function makeContext(id: string): ContextItem {
+  // Test double — only id and title are read by the code under test
   return { id, title: `Context ${id}` } as unknown as ContextItem;
 }
 
@@ -20,6 +21,7 @@ function makeAdapter(overrides: Partial<ContextNavigationAdapter> = {}): Context
     id: 'test-adapter',
     canHandle: () => true,
     encode: ({ context, currentURL }) => {
+      // Guard — adapter cannot encode without a context item
       if (!context) return null;
       return new URL(`/apps/my-app/${context.id}${currentURL.search}`, currentURL.origin);
     },
@@ -32,6 +34,7 @@ function makeAdapter(overrides: Partial<ContextNavigationAdapter> = {}): Context
 }
 
 function makeDeps(overrides: Partial<ApplyNavigationDeps> = {}): ApplyNavigationDeps {
+  // Test doubles — only the methods exercised by applyNavigation are provided
   return {
     event: {
       dispatchEvent: vi.fn(async () => ({ canceled: false })),
@@ -55,6 +58,7 @@ function makeDeps(overrides: Partial<ApplyNavigationDeps> = {}): ApplyNavigation
 
 describe('applyNavigation', () => {
   const currentURL = new URL('/apps/my-app', 'https://example.com');
+  // Test double — only the context property is accessed by the code under test
   const appModules = { context: {} } as unknown as AppModulesInstance<[ContextModule]>;
   let deps: ApplyNavigationDeps;
 
@@ -121,6 +125,7 @@ describe('applyNavigation', () => {
   });
 
   it('dispatches canceled skip when navigate event is canceled', async () => {
+    // Test double — simulates dispatch returning canceled=true only for the navigate event
     deps = makeDeps({
       event: {
         dispatchEvent: vi.fn(async (name) => ({
@@ -147,6 +152,7 @@ describe('applyNavigation', () => {
   });
 
   it('logs and does not throw when dispatch rejects', async () => {
+    // Test double — simulates dispatch throwing to verify the .catch() path
     deps = makeDeps({
       event: {
         dispatchEvent: vi.fn(async () => {

packages/plugins/context-navigation/src/__tests__/enable.test.ts

@@ -1,5 +1,5 @@
 import type { IModulesConfigurator } from '@equinor/fusion-framework-module';
-import type { ContextNavigationBuilder } from '../enable';
+import type { ContextNavigationBuilder } from '../enable-context-navigation';
 import { beforeEach, describe, expect, it, vi } from 'vitest';
 
 const builderInstances: MockContextNavigationConfigurator[] = [];
@@ -16,15 +16,24 @@ const createConfigSpy = vi.fn(() => ({
   resolveInitialContext: vi.fn(async () => undefined),
 }));
 
+/** Mock configurator that captures calls for assertion in tests. */
 class MockContextNavigationConfigurator {
+  /**
+   * Records that debug mode was configured; returns `this` for chaining.
+   *
+   * @param _enabled - Whether debug mode should be enabled.
+   * @returns The configurator instance for chaining.
+   */
   setDebug(_enabled: boolean): this {
     return this;
   }
 
+  /** Delegates to the shared spy so tests can assert how config was created. */
   createConfig() {
     return createConfigSpy();
   }
 
+  /** Registers this instance in the outer `builderInstances` array for test inspection. */
   constructor() {
     builderInstances.push(this);
   }
@@ -53,8 +62,9 @@ describe('enableContextNavigation', () => {
     const registerPlugin = vi.fn();
     const addConfig = vi.fn();
 
-    const { enableContextNavigation } = await import('../enable');
+    const { enableContextNavigation } = await import('../enable-context-navigation');
 
+    // Test double — only registerPlugin and addConfig are called by enableContextNavigation
     enableContextNavigation({
       registerPlugin,
       addConfig,
@@ -78,8 +88,9 @@ describe('enableContextNavigation', () => {
       event: { id: 'event' },
     };
 
-    const { enableContextNavigation } = await import('../enable');
+    const { enableContextNavigation } = await import('../enable-context-navigation');
 
+    // Test double — only registerPlugin is called by enableContextNavigation
     enableContextNavigation(
       {
         registerPlugin,