chore: remove unnecessary blank line in handleReplaceModeGuard function

Author: Noggling

CODEMAP.md

@@ -13,7 +13,7 @@ search to rediscover it.
 
 | Path | Contains | Published? |
 | --- | --- | --- |
-| `packages/*` | Framework libraries (58 packages) | Yes, via Changesets |
+| `packages/*` | Framework libraries (59 packages) | Yes, via Changesets |
 | `cookbooks/*` | Runnable example apps and portals | Yes (versioned, but examples) |
 | `eds-content/`, `eds/` | EDS design-system content and token tooling | No |
 | `vue-press/` | Documentation site | Partly |
@@ -82,7 +82,13 @@ Format: `package name` → path → role.
 | `@equinor/fusion-framework-react-components-bookmark` | `packages/react/components/bookmark` | Bookmark UI components |
 | `@equinor/fusion-framework-react-components-people-provider` | `packages/react/components/people-resolver` | People resolver components |
 
-### Utils (`packages/utils/*`)
+### Plugins (`packages/plugins/*`)i
+
+| Package | Path | Role |
+| --- | --- | --- |
+| `@equinor/fusion-framework-plugin-context-navigation` | `packages/plugins/context-navigation` | Plugin for context-based navigation handling |
+
+## Utils (`packages/utils/*`)
 
 | Package | Path | Role |
 | --- | --- | --- |

packages/modules/navigation/src/__tests__/NavigationProvider.test.ts

@@ -99,7 +99,7 @@ describe('NavigationProvider', () => {
     it('should handle pathological input efficiently (ReDoS protection)', () => {
       // Create a string with many consecutive slashes to test performance
       // This would cause ReDoS with certain regex patterns
-      const manySlashes = '/apps' + '/'.repeat(10000) + 'my-app';
+      const manySlashes = `/apps/${'/'.repeat(10000)}my-app`;
 
       const startTime = Date.now();
       const provider = new NavigationProvider({
@@ -117,7 +117,7 @@ describe('NavigationProvider', () => {
     it('should handle pathological trailing slashes efficiently (ReDoS protection)', () => {
       // Create a string with many trailing slashes
       // The /\/+$/ regex pattern would cause ReDoS with this input
-      const manyTrailingSlashes = '/apps/my-app' + '/'.repeat(10000);
+      const manyTrailingSlashes = `/apps/my-app${'/'.repeat(10000)}`;
 
       const startTime = Date.now();
       const provider = new NavigationProvider({
@@ -150,9 +150,13 @@ describe('NavigationProvider', () => {
       });
 
       // All paths should be in scope
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/')).toBe(true);
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/apps')).toBe(true);
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/apps/my-app')).toBe(true);
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/apps/my-app/users')).toBe(true);
 
       provider.dispose();
@@ -165,18 +169,25 @@ describe('NavigationProvider', () => {
       });
 
       // Exact match should be in scope
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/apps/my-app')).toBe(true);
 
       // Paths starting with basename/ should be in scope
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/apps/my-app/')).toBe(true);
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/apps/my-app/users')).toBe(true);
 
       // Similar but different path should NOT be in scope (path boundary check)
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/apps/my-app-other')).toBe(false);
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/apps/my-app-other/users')).toBe(false);
 
       // Completely different paths should NOT be in scope
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/other')).toBe(false);
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/')).toBe(false);
 
       provider.dispose();
@@ -189,7 +200,9 @@ describe('NavigationProvider', () => {
       });
 
       // Pathname with consecutive slashes should be normalized
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/apps//my-app')).toBe(true);
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._isWithinBasenameScope('/apps/my-app//users')).toBe(true);
 
       provider.dispose();
@@ -205,11 +218,13 @@ describe('NavigationProvider', () => {
 
       // Exact match should become '/'
       expect(
+        // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
         (provider as any)._localizePath({ pathname: '/apps/my-app', search: '', hash: '' }),
       ).toEqual({ pathname: '/', search: '', hash: '' });
 
       // Path with basename prefix should have it stripped
       expect(
+        // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
         (provider as any)._localizePath({
           pathname: '/apps/my-app/users',
           search: '?q=test',
@@ -227,6 +242,7 @@ describe('NavigationProvider', () => {
       });
 
       // Path that starts similarly but isn't a real match should not be stripped
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       const result = (provider as any)._localizePath({
         pathname: '/apps/my-app-other/users',
         search: '',
@@ -246,19 +262,22 @@ describe('NavigationProvider', () => {
       });
 
       // With no basename, paths should be returned normalized
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._localizePath({ pathname: '/', search: '', hash: '' })).toEqual({
         pathname: '/',
         search: '',
         hash: '',
       });
 
+      // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
       expect((provider as any)._localizePath({ pathname: '/apps', search: '', hash: '' })).toEqual({
         pathname: '/apps',
         search: '',
         hash: '',
       });
 
       expect(
+        // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
         (provider as any)._localizePath({ pathname: '/apps/my-app', search: '', hash: '' }),
       ).toEqual({ pathname: '/apps/my-app', search: '', hash: '' });
 
@@ -273,6 +292,7 @@ describe('NavigationProvider', () => {
 
       // Consecutive slashes should be collapsed
       expect(
+        // biome-ignore lint/suspicious/noExplicitAny: Allow usage of 'any' in test files for mocking purposes
         (provider as any)._localizePath({ pathname: '/apps//my-app//users', search: '', hash: '' }),
       ).toEqual({ pathname: '/users', search: '', hash: '' });
 

packages/plugins/context-navigation/src/apply-navigation.ts

@@ -11,7 +11,7 @@ import type {
   ContextNavigationSkippedDetail,
 } from './types';
 import type { ContextNavigationEventSource } from './create-context-navigation-plugin';
-import { normalizePath } from './helpers';
+import { normalizePathFromURL } from './helpers';
 
 /**
  * Set of normalized paths that the plugin itself has navigated to.
@@ -118,7 +118,7 @@ export async function applyNavigation(
   // Step 2: Compare normalized paths to avoid redundant navigations.
   // This prevents a replace() call when the URL is already correct, which
   // would otherwise create a spurious history entry in some browsers.
-  if (normalizePath(targetURL) === normalizePath(currentURL)) {
+  if (normalizePathFromURL(targetURL) === normalizePathFromURL(currentURL)) {
     event.dispatchEvent('onContextNavigationSkipped', {
       detail: { appKey, reason: 'url-matches' } as ContextNavigationSkippedDetail,
       source: eventSource,
@@ -156,7 +156,7 @@ export async function applyNavigation(
 
       // Step 4: Record the token BEFORE navigating so the guard sees it
       // on the resulting state$ emission and skips re-processing.
-      ownNavTokens.add(normalizePath(targetURL));
+      ownNavTokens.add(normalizePathFromURL(targetURL));
       navigation.navigate(targetURL, navOptionsOverride ?? config.navigationOptions);
 
       // Post-navigation bookkeeping: notify listeners and invoke callback.

packages/plugins/context-navigation/src/create-context-navigation-plugin.ts

@@ -108,8 +108,8 @@ export function createContextNavigationPlugin(args: ContextNavigationPluginArgs)
         startWith(null),
         pairwise(),
         map(([prev, entry]) => ({
-          entry: entry!,
-          isAppSwitch: prev != null && prev.appKey !== entry!.appKey,
+          entry: entry as typeof entry & {},
+          isAppSwitch: prev != null && prev.appKey !== (entry as typeof entry & {}).appKey,
         })),
       )
       .subscribe(({ entry, isAppSwitch }) => {

packages/plugins/context-navigation/src/guard-handlers/consume-own-nav-token.ts

@@ -1,4 +1,4 @@
-import { normalizePath } from '../helpers';
+import { normalizePathFromURL } from '../helpers';
 import type { OwnNavigationTokens } from '../apply-navigation';
 
 /**
@@ -20,8 +20,8 @@ import type { OwnNavigationTokens } from '../apply-navigation';
  * @returns `true` if this navigation was plugin-initiated (caller should bail).
  */
 export function consumeOwnNavToken(currentURL: URL, ownNavTokens: OwnNavigationTokens): boolean {
-  const normalized = normalizePath(currentURL);
-  
+  const normalized = normalizePathFromURL(currentURL);
+
   // Token present — this navigation was plugin-initiated; consume it and signal the caller to bail.
   if (ownNavTokens.has(normalized)) {
     ownNavTokens.delete(normalized);

packages/plugins/context-navigation/src/guard-handlers/handle-push-mode-guard.ts

@@ -40,7 +40,7 @@ export function handlePushModeGuard(
   if (!activeContext) {
     return;
   }
-  
+
   const adapter = resolveAdapter(
     { appKey, appContext: appModules.context, routingStrategy, currentURL },
     deps.config.adapters,

packages/plugins/context-navigation/src/guard-handlers/handle-replace-mode-guard.ts

@@ -29,7 +29,7 @@ export function handleReplaceModeGuard(
 
   // Resolve the active context and adapter for re-encoding.
   const activeContext = appModules.context.currentContext;
-  
+
   // No active context to re-encode — nothing to correct.
   if (!activeContext) {
     return;

packages/plugins/context-navigation/src/helpers/index.ts

@@ -1,3 +1,4 @@
+export { normalizePathFromURL } from './normalize-path-from-url';
 export { normalizePath } from './normalize-path';
 export { getCurrentURL } from './get-current-url';
 export { resolveAdapter } from './resolve-adapter';

packages/plugins/context-navigation/src/helpers/normalize-path-from-url.ts

@@ -0,0 +1,13 @@
+import { normalizePath } from './normalize-path';
+/**
+ * Normalize a URL to its path + search representation for comparison.
+ *
+ * Strips trailing slashes from the pathname so that `/apps/foo/` and
+ * `/apps/foo` compare as equal.
+ *
+ * @param url - The URL to normalize.
+ * @returns A string of the form `pathname + search` with trailing slash removed.
+ */
+export function normalizePathFromURL(url: URL): string {
+  return `${normalizePath(url.pathname)}${url.search}`;
+}

packages/plugins/context-navigation/src/helpers/normalize-path.ts

@@ -1,12 +1,33 @@
 /**
- * Normalize a URL to its path + search representation for comparison.
+ * Normalizes a path string to ensure it is in a consistent format for comparison and processing.
  *
- * Strips trailing slashes from the pathname so that `/apps/foo/` and
- * `/apps/foo` compare as equal.
+ * This function performs the following normalizations:
+ * - Ensures the path starts with a leading slash.
+ * - Removes any trailing slashes, except for the root path ("/").
+ * - Converts empty paths to the root path ("/").
+ * - Fixing multiple consecutive slashes to a single slash.
  *
- * @param url - The URL to normalize.
- * @returns A string of the form `pathname + search` with trailing slash removed.
+ * @param path - The path string to normalize.
+ * @returns The normalized path string.
  */
-export function normalizePath(url: URL): string {
-  return `${url.pathname.replace(/\/$/, '') || '/'}${url.search}`;
+export function normalizePath(path: string): string {
+  // Replace multiple consecutive slashes with a single slash
+  path = path.replace(/\/+/g, '/');
+
+  // Ensure the path starts with a leading slash
+  if (!path.startsWith('/')) {
+    path = `/${path}`;
+  }
+
+  // Remove trailing slashes, except for the root path
+  if (path.length > 1 && path.endsWith('/')) {
+    path = path.slice(0, -1);
+  }
+
+  // Convert empty paths to the root path
+  if (path === '') {
+    return '/';
+  }
+
+  return path;
 }