Skip to content

Commit 48e4595

Browse files
committed
fix(msal): make AuthProvider extend BaseModuleProvider
- Fixed AuthProvider class to properly extend BaseModuleProvider - Eliminates module initialization warnings about provider inheritance - AuthProvider now inherits standard version property and dispose method
1 parent c828334 commit 48e4595

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@equinor/fusion-framework-module-msal": patch
3+
---
4+
5+
Fixed AuthProvider to properly extend BaseModuleProvider, eliminating module initialization warnings about provider inheritance.
6+
7+
The AuthProvider class now inherits the standard version property and dispose method from BaseModuleProvider, ensuring proper integration with the Fusion Framework's module system.

packages/modules/msal/src/v2/provider.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import type { AuthClientConfig } from './configurator';
66
import type { AccountInfo, AuthenticationResult } from './types';
77
import type { IProxyProvider } from '../types';
88
import { resolveVersion } from '../versioning/resolve-version';
9-
import { SemanticVersion } from '@equinor/fusion-framework-module';
9+
import { BaseModuleProvider } from '@equinor/fusion-framework-module/provider';
1010

1111
export interface IAuthProvider {
1212
// readonly defaultClient: AuthClient;
@@ -47,13 +47,9 @@ export interface IAuthProvider {
4747
handleRedirect(): Promise<void | null>;
4848
}
4949

50-
export class AuthProvider implements IAuthProvider, IProxyProvider {
50+
export class AuthProvider extends BaseModuleProvider<AuthClientConfig> implements IAuthProvider, IProxyProvider {
5151
#client: AuthClient;
5252

53-
get version(): SemanticVersion {
54-
return new SemanticVersion(MsalModuleVersion.Latest);
55-
}
56-
5753
get defaultAccount(): AccountInfo | undefined {
5854
return this.client.account;
5955
}
@@ -64,6 +60,10 @@ export class AuthProvider implements IAuthProvider, IProxyProvider {
6460
}
6561

6662
constructor(protected _config: AuthClientConfig) {
63+
super({
64+
version: MsalModuleVersion.Latest,
65+
config: _config,
66+
});
6767
this.#client = this.createClient();
6868
}
6969

@@ -140,13 +140,13 @@ export class AuthProvider implements IAuthProvider, IProxyProvider {
140140

141141
_createProxyProvider_v2(): IAuthProvider {
142142
return new Proxy(this, {
143-
get: (target: AuthProvider, prop: keyof AuthProvider) => {
143+
get: (target: AuthProvider, prop: string | symbol) => {
144144
switch (prop) {
145145
case 'version':
146146
return target.version;
147147
case 'client':
148148
return target.client;
149-
// @ts-expect-error - this is deprecated since version 5.0.1
149+
// @deprecated this is deprecated since version 5.0.1
150150
case 'defaultClient':
151151
console.warn('defaultClient is deprecated, use client instead');
152152
return target.client;

0 commit comments

Comments
 (0)