fix: EventModuleProvider now extends BaseModuleProvider (#3596)

* fix: EventModuleProvider extends BaseModuleProvider and removes subscribe method

- EventModuleProvider now extends BaseModuleProvider as required by module system
- Removed subscribe method from interface and implementation
- Consumers should use event$.subscribe() for full RxJS Observable functionality
- Updated documentation and changeset with migration notes
- Uses BaseModuleProvider teardown system for proper cleanup

BREAKING CHANGE: modules.event.subscribe() removed, use modules.event.event$.subscribe() instead

* Update packages/modules/event/src/provider.ts

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: odinr

.changeset/event-module-provider-fix.md

@@ -0,0 +1,11 @@
+---
+"@equinor/fusion-framework-module-event": minor
+---
+
+Fix EventModuleProvider to extend BaseModuleProvider as required by the module system. This resolves telemetry errors indicating the provider was not properly extending the base class.
+
+Also removed the subscribe method from the IEventModuleProvider interface and implementation, as consumers can use the event$ Observable property for subscription instead.
+
+**Migration:** Replace `modules.event.subscribe(...)` with `modules.event.event$.subscribe(...)`. The `event$` property provides full Observable functionality including `pipe`, `map`, `filter`, and other RxJS operators.
+
+*Note: Using minor version bump since the framework internally does not use subscribe or pipe on the event module.*

packages/modules/event/README.md

@@ -92,9 +92,9 @@ if(!event.defaultPrevent){
 ### Subscribe to all events
 > note that when subscribing to events, it does not allow side-effects, like `preventDefault` and `stopPropagation`
 ```ts
-const subscription = modules.event.subscribe(console.log);
+const subscription = modules.event.event$.subscribe(console.log);
 subscription.add(
-  modules.event.subscribe({
+  modules.event.event$.subscribe({
     next: (event) => console.log(event),
     error: (err) => console.error(err),
     complete: () => 'event provider disposed'

packages/modules/event/src/provider.ts

@@ -1,4 +1,7 @@
-import { Observable, type Observer, Subject, type Subscription } from 'rxjs';
+import { type Observable, Subject } from 'rxjs';
+
+import { BaseModuleProvider } from '@equinor/fusion-framework-module/provider';
+import { version } from './version.js';
 
 import type { IEventModuleConfigurator } from './configurator';
 import { FrameworkEventDispatcher, type FrameworkEventHandler } from './dispatcher';
@@ -12,15 +15,16 @@ import {
 } from './event';
 
 export interface IEventModuleProvider {
+  /** Observable stream of all dispatched events for subscription */
   readonly event$: Observable<IFrameworkEvent>;
 
-  /** subscribe to a known mapped event @see {@link FrameworkEventMap} */
+  /** listen to a known mapped event @see {@link FrameworkEventMap} */
   addEventListener<TKey extends keyof FrameworkEventMap>(
     type: TKey,
     handler: FrameworkEventHandler<FrameworkEventMap[TKey]>,
   ): VoidFunction;
 
-  /** subscribe to generic type */
+  /** listen to generic type events */
   addEventListener<TType extends FrameworkEvent = FrameworkEvent>(
     type: string,
     handler: FrameworkEventHandler<TType>,
@@ -43,23 +47,11 @@ export interface IEventModuleProvider {
     event: TType,
   ): Promise<FrameworkEvent>;
 
-  /**
-   * subscribe to events
-   * __note__: does not allow side effects
-   */
-  subscribe(observer?: Partial<Observer<IFrameworkEvent>>): Subscription;
-
-  /**
-   * subscribe to events
-   * __note__: does not allow side effects
-   */
-  subscribe(next: (value: IFrameworkEvent) => void): Subscription;
-
   dispose: VoidFunction;
 }
 
 export class EventModuleProvider
-  extends Observable<IFrameworkEvent>
+  extends BaseModuleProvider<IEventModuleConfigurator>
   implements IEventModuleProvider
 {
   private __listeners: Array<{
@@ -80,13 +72,17 @@ export class EventModuleProvider
   }
 
   constructor(config: IEventModuleConfigurator) {
-    super((subscriber) => {
-      this.__event$.subscribe(subscriber);
-    });
+    super({ version, config });
     this.__dispatcher = new FrameworkEventDispatcher({
       onDispatch: config.onDispatch,
       onBubble: config.onBubble,
     });
+    // complete the event$ subject when the provider is disposed
+    // and clear the listeners
+    this._addTeardown(() => {
+      this.__listeners = [];
+      this.__event$.complete();
+    });
   }
 
   public addEventListener(type: string, handler: FrameworkEventHandler): VoidFunction {
@@ -132,9 +128,4 @@ export class EventModuleProvider
     }
     return event;
   }
-
-  public dispose() {
-    this.__listeners = [];
-    this.__event$.complete();
-  }
 }