fix(module-analytics): reject waitForAnalytic when a predicate matcher throws

A throwing predicate matcher surfaced on RxJS's error channel, but the
subscribe observer had no error handler — the exception was reported
globally and the returned promise stayed pending forever. Add an error
handler that rejects through the same cleanup path, and cover it with a test.

Author: odinr

packages/modules/analytics/src/__tests__/MockAnalyticsAdapter.test.ts

@@ -103,6 +103,18 @@ describe('MockAnalyticsAdapter', () => {
     await expect(promise).rejects.toThrow('disposed before a matching event was recorded');
   });
 
+  it('rejects instead of hanging when a predicate matcher throws on a future event', async () => {
+    const adapter = new MockAnalyticsAdapter();
+    const boom = new Error('predicate boom');
+
+    const promise = adapter.waitForAnalytic(() => {
+      throw boom;
+    });
+    adapter.registerAnalytic(createEvent('button-click'));
+
+    await expect(promise).rejects.toThrow(boom);
+  });
+
   it('does not interfere with events recorded by another adapter instance', () => {
     const adapterA = new MockAnalyticsAdapter();
     const adapterB = new MockAnalyticsAdapter();

packages/modules/analytics/src/mock/MockAnalyticsAdapter.ts

@@ -123,6 +123,11 @@ export class MockAnalyticsAdapter<T extends AnalyticsEvent = AnalyticsEvent>
           cleanup();
           resolve(event);
         },
+        // A throwing predicate matcher surfaces here instead of hanging the promise forever.
+        error: (err) => {
+          cleanup();
+          reject(err);
+        },
         complete: () => {
           cleanup();
           reject(new Error('MockAnalyticsAdapter disposed before a matching event was recorded'));