refactor(module-msal): simplify isRequestV4 type check

odinr · odinr · commit f48a04d74510 · 2025-11-25T13:50:41.000+01:00
Remove redundant type checks in isRequestV4 function since we already
validate that the input is an object before checking for the request property.
diff --git a/packages/modules/msal/src/v2/create-proxy-provider.ts b/packages/modules/msal/src/v2/create-proxy-provider.ts
@@ -19,11 +19,7 @@ function isRequestV4(
     return false;
   }
   const requestV4 = req as AcquireTokenOptions;
-  return (
-    typeof requestV4.request === 'object' &&
-    requestV4.request !== null &&
-    'request' in requestV4
-  );
+  return 'request' in requestV4;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -19,11 +19,7 @@ function isRequestV4(`
`19`	`19`	`return false;`
`20`	`20`	`}`
`21`	`21`	`const requestV4 = req as AcquireTokenOptions;`
`22`		`- return (`
`23`		`- typeof requestV4.request === 'object' &&`
`24`		`- requestV4.request !== null &&`
`25`		`- 'request' in requestV4`
`26`		`- );`
	`22`	`+ return 'request' in requestV4;`
`27`	`23`	`}`
`28`	`24`
`29`	`25`	`/**`