Skip to content

module: consider ObservableInput return types for Module.configure/postConfigure #5146

Description

@odinr

Context

packages/modules/module/src/types.ts defines the Module<TKey, TType, TConfig, TDeps> interface. Its configure and postConfigure members currently return TConfig | Promise<TConfig> and void | Promise<void> respectively.

Task

  • Consider changing the return types of configure/postConfigure to ObservableInput<TConfig> / ObservableInput<void> (or similar) for consistency with the rest of the framework's observable-based APIs.
  • Add a reference/link to IConfigurationBuilder in the configure member's TSDoc, once such a type exists or is identified.

Note

Filed while resolving no-todo-without-issue fusion-lint warnings on pre-existing // @todo comments above Module.configure and Module.postConfigure.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions