Skip to content

Commit edc6450

Browse files
committed
Fix the hello-world example so it works with OCI
1 parent 25351a1 commit edc6450

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

examples/hello_world/Containerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
FROM alpine
2+
RUN apk add bash

src/deploy/builder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ async def _async_build(
123123

124124
proc = await ctx.engine(
125125
pkg.build_image,
126-
"/bin/bash",
126+
"bash",
127127
"/dev/stdin",
128128
env=env,
129129
cwd=cwd,

src/deploy/engine.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import hashlib
55
import os
66
from pathlib import Path
7-
import sys
87
from typing import Literal, Protocol, TypeAlias
98

109

@@ -71,11 +70,6 @@ async def _engine(
7170
volumes = volumes or []
7271
image_id = await _engine_ensure_image(which, image)
7372

74-
for src, _, kind in volumes:
75-
if kind == "rw":
76-
print("Creating directory", src)
77-
Path(src).mkdir(parents=True, exist_ok=True)
78-
7973
stdin = None
8074
if input is not None:
8175
stdin = PIPE
@@ -156,7 +150,7 @@ async def _native(
156150

157151
def get_engine(preference: EngineName | None = None) -> Engine:
158152
if preference is None:
159-
preference = "docker" if sys.platform == "darwin" else "podman"
153+
preference = "podman"
160154

161155
match preference:
162156
case "podman":

0 commit comments

Comments
 (0)