Skip to content

Inconsistency in naming #110

@lars-petter-hauge

Description

@lars-petter-hauge

So, the Config contains an entry named packages, which contains a list of BuildConfig. There is also a Package class, which contains a single instance of BuildConfig, in addittion to some other properties.

Would it be possible to make sure if we have a list of packages this would be then reflected as a list of Package instances? Or some way of making this more consistent.. (edit: I think renaming BuildConfig to PackageConfig or PkgConfig would suffice)

Also, while reading the code I feel like PackageList should only contain the sorting mechanism, that is, given a set of packages, provide install order. The placement of storepaths and volumes seems off. we might want to reconsider where those are placed. Context sounds like a good place, just by the name, although I have looked much at the class yet.

(Edit; I see that packagelist is the one creating the packages, and there needs storepath. But perhaps those packages should be created upfront and packagelist gets a list of package instances and simply sorts them)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions