fix: switch from restriction entry preventing outcome/option deletion to on delete cleanup (#427)

Author: EinarSalbouvet

PrismaDotnetApi/PrismaApi.Application/Repositories/EntitiesExtensions.cs

@@ -241,7 +241,7 @@ public static async Task<Uncertainty> Update(this Uncertainty entity, Uncertaint
         await entity.Outcomes.Update(incomingEntity.Outcomes, context, ruleTrigger, ct);
         entity.IssueId = incomingEntity.IssueId;
         entity.IsKey = incomingEntity.IsKey;
-        entity.DiscreteProbabilities.Update(incomingEntity.DiscreteProbabilities, context);
+        entity.DiscreteProbabilities.UpdateProperties(incomingEntity.DiscreteProbabilities, context);
         return entity;
     }
 
@@ -278,10 +278,20 @@ public static void Update(this ICollection<DiscreteProbability> entities, IColle
         }
     }
 
+    public static void UpdateProperties(this ICollection<DiscreteProbability> entities, ICollection<DiscreteProbability> incomingEntities, AppDbContext context)
+    {
+        foreach (var entity in entities)
+        {
+            var inncommingEntity = incomingEntities.Where(x => x.Id == entity.Id).FirstOrDefault();
+            if (inncommingEntity == null) continue;
+            entity.Probability = inncommingEntity.Probability;
+        }
+    }
+
     public static Utility Update(this Utility entity, Utility incomingEntity, AppDbContext context, CancellationToken ct = default)
     {
         entity.IssueId = incomingEntity.IssueId;
-        entity.DiscreteUtilities.Update(incomingEntity.DiscreteUtilities, context);
+        entity.DiscreteUtilities.UpdateProperties(incomingEntity.DiscreteUtilities, context);
         return entity;
     }
 
@@ -297,6 +307,16 @@ public static void Update(this ICollection<DiscreteUtility> entities, ICollectio
         }
     }
 
+    public static void UpdateProperties(this ICollection<DiscreteUtility> entities, ICollection<DiscreteUtility> incomingEntities, AppDbContext context)
+    {
+        foreach (var entity in entities)
+        {
+            var inncommingEntity = incomingEntities.Where(x => x.Id == entity.Id).FirstOrDefault();
+            if (inncommingEntity == null) continue;
+            entity.UtilityValue = inncommingEntity.UtilityValue;
+        }
+    }
+
     public static async Task RemoveOutOfScopeStrategyOptions(this Issue entity, Issue incomingEntity, AppDbContext context, CancellationToken ct = default)
     {
         if (!RepositoryUtilities.IsDecisionMovedOutOfStrategyTable(entity, incomingEntity)) return;

PrismaDotnetApi/PrismaApi.Domain/Entities/RestrictionEntry.cs

@@ -50,22 +50,22 @@ public static void OnModelConfiguring(ModelBuilder modelBuilder)
             entity.HasOne(e => e.ParentOption)
                 .WithMany()
                 .HasForeignKey(e => e.ParentOptionId)
-                .OnDelete(DeleteBehavior.Restrict);
+                .OnDelete(DeleteBehavior.NoAction);
 
             entity.HasOne(e => e.ChildOption)
                 .WithMany()
                 .HasForeignKey(e => e.ChildOptionId)
-                .OnDelete(DeleteBehavior.Restrict);
+                .OnDelete(DeleteBehavior.NoAction);
 
             entity.HasOne(e => e.ParentOutcome)
                 .WithMany()
                 .HasForeignKey(e => e.ParentOutcomeId)
-                .OnDelete(DeleteBehavior.Restrict);
+                .OnDelete(DeleteBehavior.NoAction);
 
             entity.HasOne(e => e.ChildOutcome)
                 .WithMany()
                 .HasForeignKey(e => e.ChildOutcomeId)
-                .OnDelete(DeleteBehavior.Restrict);
+                .OnDelete(DeleteBehavior.NoAction);
 
             entity.Property<Guid>(e => e.ParentStateId) 
                 .HasComputedColumnSql($"COALESCE([{nameof(ParentOptionId)}], [{nameof(ParentOutcomeId)}])", stored: true);

PrismaDotnetApi/PrismaApi.Infrastructure/Context/AppDbContext.cs

@@ -233,6 +233,13 @@ private async Task OnOutcomeDeletedCleanupAsync(CancellationToken cancellationTo
                 .ToList();
 
             DiscreteUtilities.RemoveRange(affectedUtils);
+
+            var affectedRestrictionEntries = await RestrictionEntries
+                .Where(
+                    re => (re.ParentOutcomeId != null && deletedOutcomeIds.Contains((Guid)re.ParentOutcomeId)) || 
+                    (re.ChildOutcomeId != null && deletedOutcomeIds.Contains((Guid)re.ChildOutcomeId)))
+                .ToListAsync(cancellationToken);
+            RestrictionEntries.RemoveRange(affectedRestrictionEntries);
         }
     }
     private async Task OnOptionDeletedCleanupAsync(CancellationToken cancellationToken = default)
@@ -286,6 +293,13 @@ private async Task OnOptionDeletedCleanupAsync(CancellationToken cancellationTok
 
             DiscreteUtilities.RemoveRange(affectedUtils);
             DiscreteUtilityParentOptions.RemoveRange(affectedUtilParentOptions);
+
+            var affectedRestrictionEntries = await RestrictionEntries
+                .Where(
+                    re => (re.ParentOptionId != null && deletedOptionIds.Contains((Guid)re.ParentOptionId)) || 
+                    (re.ChildOptionId != null && deletedOptionIds.Contains((Guid)re.ChildOptionId)))
+                .ToListAsync(cancellationToken);
+            RestrictionEntries.RemoveRange(affectedRestrictionEntries);
         }
     }