refactor: update PointersOf function to return pointers to elements and clean up tests

Author: nilsgstrabo

README.md

@@ -92,8 +92,7 @@ Comprehensive utility functions for common operations.
 | Package | Functions |
 |---------|-----------|
 | `utils/slice` | `Map()`, `Reduce()`, `Any()`, `All()`, `FindAll()`, `FindFirst()`, `FindIndex()` |
-| `utils/pointers` | `Ptr[T]()`, `Val[T]()` — Generic pointer/value conversion |
-| `utils/maps` | `GetKeysFromMap()`, `MergeMaps()`, `FromString()`, `ToString()` |
+| `utils/pointers` | `Val[T]()` — Generic pointer-to-value conversion |
 | `utils/json` | `Save()`, `Load()`, `Pretty()` — Thread-safe JSON file I/O |
 | `utils/timewindow` | `TimeWindow` — Cron-like schedule validation (day + time range) |
 | `utils/errors` | Custom error utilities |
@@ -104,7 +103,6 @@ import "github.com/equinor/radix-common/utils/slice"
 import "github.com/equinor/radix-common/utils/pointers"
 
 doubled := slice.Map(numbers, func(n int) int { return n * 2 })
-ptr := pointers.Ptr("value")
 val := pointers.Val(ptr)
 ```
 

utils/slice/utils.go

@@ -4,12 +4,12 @@ import (
 	"slices"
 )
 
-// PointersOf returns a slice of pointers to copies of each element in the provided slice.
+// PointersOf returns a slice of pointers to each element in the provided slice.
 func PointersOf[S ~[]E, E any](s S) []*E {
 	ptrSlice := make([]*E, len(s))
 
-	for i, v := range s {
-		ptrSlice[i] = &v
+	for i := range s {
+		ptrSlice[i] = &s[i]
 	}
 
 	return ptrSlice

utils/slice/utils_test.go

@@ -39,12 +39,6 @@ func Test_PointersOf(t *testing.T) {
 		result := slice.PointersOf(src)
 		assert.NotSame(t, result[0], result[1])
 	})
-	t.Run("modifying source does not affect returned pointers", func(t *testing.T) {
-		src := []obj{{"original"}}
-		result := slice.PointersOf(src)
-		src[0].prop = "mutated"
-		assert.Equal(t, "original", result[0].prop)
-	})
 	t.Run("modifying returned pointer does not affect other pointers", func(t *testing.T) {
 		src := []obj{{"a"}, {"b"}}
 		result := slice.PointersOf(src)