Merge pull request #570 from SaidBenaissa/fix_std_uint16_t_error

Add missing includes and add simple test for includes in public headers

Author: ajaust

lib/CMakeLists.txt

@@ -139,3 +139,19 @@ add_test(NAME c.segy.mmap     COMMAND c.segy [c.segy] --test-mmap)
 add_test(NAME c.segy.lsb      COMMAND c.segy [c.segy] --test-lsb)
 add_test(NAME c.segy.mmap.lsb COMMAND c.segy [c.segy] --test-mmap --test-lsb)
 add_test(NAME cpp.segy        COMMAND c.segy [c++])
+
+
+# These targets check if code that includes the public C and C++ header compile
+# correctly. This is done to detect issues like missing includes directives in
+# these headers of segyio. Missing includes may not be picked up by the tests
+# above because the test framework does include some C++ dependencies like
+# `cstdint` and `algorithm` that may be used in the segyio headers.
+add_executable(c-include.segy test/test-include.c)
+target_link_libraries(c-include.segy segyio)
+target_include_directories(c-include.segy PRIVATE src)
+add_test(NAME c-include.segy COMMAND c-include.segy)
+
+add_executable(cpp-include.segy test/test-include.cpp)
+target_link_libraries(cpp-include.segy segyio::segyio)
+target_include_directories(cpp-include.segy PRIVATE experimental)
+add_test(NAME cpp-include.segy COMMAND cpp-include.segy)

lib/experimental/segyio/segyio.hpp

@@ -1,12 +1,15 @@
 #ifndef SEGYIO_HPP
 #define SEGYIO_HPP
 
+#include <algorithm>
 #include <cerrno>
+#include <cstdint>
 #include <cstring>
 #include <exception>
 #include <functional>
 #include <iterator>
 #include <memory>
+#include <stdexcept>
 #include <string>
 #include <type_traits>
 #include <utility>

lib/test/test-include.c

@@ -0,0 +1,5 @@
+#include <segyio/segy.h>
+
+int main(void) {
+    return 0;
+}

lib/test/test-include.cpp

@@ -0,0 +1,10 @@
+#include <segyio/segyio.hpp>
+
+int main() {
+    // Open a SEG-Y file to avoid error about unused internal functions.
+    segyio::basic_volume< segyio::readonly > tmp(
+        segyio::path{ "test-data/small.sgy" },
+        segyio::config{}
+    );
+    return 0;
+}