Skip to content

Commit 177e479

Browse files
author
tommyod
committed
nitpick
1 parent 39d9ee0 commit 177e479

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

src/semeio/fmudesign/create_design.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -857,7 +857,7 @@ def generate(
857857

858858
if not is_consistent_correlation_matrix(correlations):
859859
print(
860-
f"\nWarning: Correlation matrix {corr_group_name!r} is not consistent"
860+
f"\nWarning: Correlation matrix {corr_group_name!r} is invalid"
861861
)
862862
print("Requirements:")
863863
print(" - Ones on the diagonal")
@@ -875,7 +875,7 @@ def generate(
875875
expression.correlate(*corrvars, corr_mat=df_correlations.values)
876876
self.correlation_dfs_[corr_group_name] = df_correlations
877877

878-
# Sample the dummy node - this samples every parent and populates "samples_"
878+
# Either do ImanConover followed by Permutation, or simply ImanConover
879879
if correlation_iterations > 0:
880880
correlator = probabilit.correlation.Composite(
881881
iterations=correlation_iterations,
@@ -886,6 +886,7 @@ def generate(
886886
else:
887887
correlator = probabilit.correlation.ImanConover()
888888

889+
# Sample the dummy node - this samples every parent and populates "samples_"
889890
expression.sample(
890891
size=numreals, random_state=rng, method="lhs", correlator=correlator
891892
)
@@ -895,7 +896,8 @@ def generate(
895896
is_numeric = issubclass(samples.dtype.type, np.number)
896897
if is_numeric and not np.all(np.isfinite(distr_obj.samples_)):
897898
raise ValueError(
898-
f"Sampling produced non-finite values in {distr_name}={distr_obj}"
899+
f"Sampling produced non-finite values in {distr_name}={distr_obj}\n"
900+
"Please review the parameters in the distribution."
899901
)
900902

901903
# Discrete distributions are handled in a special way. We map them
@@ -911,7 +913,7 @@ def generate(
911913
)
912914

913915
self.sensvalues = self.sensvalues.assign(**{distr_name: samples})
914-
print(f"Wrote {numreals} samples from {distr_name!r} {distr_obj}")
916+
print(f"Wrote {numreals} samples from {distr_name!r}")
915917

916918
if self.sensname != "background":
917919
self.sensvalues["REAL"] = realnums

0 commit comments

Comments
 (0)