Remove redundant validation

These properties are already validated in validate_general_input

Author: SAKavli

src/semeio/fmudesign/config_validation.py

@@ -3,7 +3,6 @@
 """
 
 import copy
-import numbers
 from enum import StrEnum
 from typing import Any
 
@@ -37,15 +36,6 @@ def validate_configuration(
     """
     config = copy.deepcopy(config)
 
-    if config["designtype"] != "onebyone":
-        raise ValueError(
-            "Generation of DesignMatrix only implemented for type 'onebyone', "
-            f"not {config['designtype']}"
-        )
-
-    if "repeats" not in config:
-        raise LookupError('"repeats" must be specified in general input sheet')
-
     key = "correlation_iterations"
     if key not in config:
         if verbosity > 0:
@@ -60,29 +50,6 @@ def validate_configuration(
                 f"  If desired correlation does not match observed, try setting {key!r}=999 or higher."  # ruff: ignore[line-too-long]
             )
         config[key] = 0
-    else:
-        try:
-            config[key] = int(config[key])
-        except (ValueError, TypeError) as err:
-            raise ValueError(
-                f"{key!r} must be a non-negative integer, got: {config[key]}"
-            ) from err
-
-    key = "distribution_seed"
-    if key not in config:
-        raise ValueError(
-            "You did not specify a value for 'distribution_seed', which is used to "
-            "seed the random number generator that draws from distributions in Monte "
-            "Carlo sensitivities.\n"
-            "- Specify a number (e.g. a 6 digit integer) to seed the random number "
-            "generator and obtain reproducible results.\n"
-            "- Specify None if you do not want to seed the random number generator. "
-            "Your analysis will not be reproducible."
-        )
-    if not (isinstance(config[key], numbers.Integral) or (config[key] is None)):
-        raise ValueError(
-            f"{key!r} must be a non-negative integer or None, got: {config[key]}"
-        )
 
     # 'seed_strategy' controls how Monte Carlo samples are seeded.
     # See the SeedStrategy docstring for what each strategy means.
@@ -92,13 +59,7 @@ def validate_configuration(
         value = value.strip().lower()
     if value is None or value == "none":
         value = SeedStrategy.JOINT
-    try:
-        config[key] = SeedStrategy(value)
-    except (ValueError, TypeError) as err:
-        raise ValueError(
-            f"{key!r} must be one of {[s.value for s in SeedStrategy]}, "
-            f"got: {config[key]}"
-        ) from err
+    config[key] = SeedStrategy(value)
 
     # 'seeds' here is 'rms_seeds' in the input. It can be either:
     # - 'default' => gives seed numbers 1000, 1001, 1002, ...

tests/fmudesign/test_config_validation.py

@@ -26,25 +26,6 @@ def test_seed_strategy_is_normalized_to_enum_member():
     assert cfg["seed_strategy"] == "independent"
 
 
-def test_seed_strategy_invalid_raises():
-    with pytest.raises(ValueError, match="seed_strategy"):
-        validate_configuration(_minimal_config(seed_strategy="bogus"))
-
-
-@pytest.mark.parametrize("value", [["independent"], {"joint": 1}, 5, 1.5])
-def test_seed_strategy_non_string_raises_value_error(value):
-    """Unsupported types must be rejected as validation errors, not TypeErrors."""
-    with pytest.raises(ValueError, match="seed_strategy"):
-        validate_configuration(_minimal_config(seed_strategy=value))
-
-
-@pytest.mark.parametrize("value", ["Independent", "INDEPENDENT", " independent "])
-def test_seed_strategy_is_case_and_whitespace_insensitive(value):
-    """Excel auto-capitalizes cell text, so 'Independent' must be accepted."""
-    cfg = validate_configuration(_minimal_config(seed_strategy=value))
-    assert cfg["seed_strategy"] is SeedStrategy.INDEPENDENT
-
-
 @pytest.mark.parametrize("value", [None, "None"])
 def test_seed_strategy_none_falls_back_to_joint(value):
     cfg = validate_configuration(_minimal_config(seed_strategy=value))