Pin react version to 18.2.0 (#304)

* Pin react version to 18.2.0
* Removed unnecessary error comments

Author: rubenthoms

CHANGELOG.md

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [UNRELEASED] - YYYY-MM-DD
+
+### Changed
+-   [#304](https://github.com/equinor/webviz-core-components/pull/304) - Pinned `React` to version `18.2` in `package-lock.json` in order to comply with supported versions in `Dash`.
+
 ## [0.7.0] - 2024-01-29
 
 ### Changed

react/package-lock.json

@@ -126,7 +126,6 @@ export const DialogComponent: React.FC<DialogProps> = (props) => {
                         color: "#ccc",
                     }}
                 >
-                    { /* @ts-expect-error - this is a very weird bug */}
                     <Icon name="close" />
                 </IconButton>
             </DialogTitle>

react/src/lib/components/Dialog/components/DialogComponent.tsx

@@ -28,7 +28,6 @@ export const EdsIcon: React.FC<EdsIconProps> = (props) => {
                     `https://eds-storybook-react.azurewebsites.net/?path=/story/icons--preview.`
                 }
             >
-                { /* @ts-expect-error - this is a very weird bug */}
                 <Icon
                     id={props.id}
                     data={edsIcons.report}
@@ -42,7 +41,6 @@ export const EdsIcon: React.FC<EdsIconProps> = (props) => {
 
     return (
         <>
-        { /* @ts-expect-error - this is a very weird bug */}
         <Icon id={props.id} data={icon} size={props.size} color={props.color} />
         </>
     );

react/src/lib/components/EdsIcon/EdsIcon.tsx

@@ -73,7 +73,6 @@ export const Group: React.FC<GroupProps> = (props) => {
                             : "Collapse group"
                     }
                 >
-                    { /* @ts-expect-error - this is a very weird bug */}
                     <EdsIcon
                         name={
                             !collapsed || props.forceOpen

react/src/lib/components/Menu/components/Group/Group.tsx

@@ -27,7 +27,6 @@ export const Icon: React.FC<IconProps> = (props) => {
                     `https://eds-storybook-react.azurewebsites.net/?path=/story/icons--preview.`
                 }
             >
-                { /* @ts-expect-error - this is a very weird bug */}
                 <EdsIcon
                     data={edsIcons.report}
                     color="hsla(0, 100%, 50%, 1)"
@@ -39,7 +38,6 @@ export const Icon: React.FC<IconProps> = (props) => {
 
     return (
         <>
-        { /* @ts-expect-error - this is a very weird bug */}
         <EdsIcon
             data={icon}
             color={props.active ? "#FF1243" : "#989898"}

react/src/lib/components/Menu/components/Icon/Icon.tsx

@@ -331,7 +331,6 @@ export const MenuBar = React.forwardRef<HTMLDivElement, MenuBarProps>(
                         variant="ghost_icon"
                         onClick={handleMenuButtonClick}
                     >
-                        { /* @ts-expect-error - this is a very weird bug */}
                         <Icon name="menu" title="Open menu" />
                     </Button>
                 </div>

react/src/lib/components/Menu/components/MenuBar/MenuBar.tsx

@@ -74,7 +74,6 @@ export const WebvizDialogTitle = React.forwardRef<
                         aria-label="close"
                         onClick={() => handleCloseClick()}
                     >
-                        { /* @ts-expect-error - this is a very weird bug */}
                         <Icon name="close" />
                     </IconButton>
                 </div>

react/src/lib/components/WebvizDialog/components/WebvizDialogTitle/WebvizDialogTitle.tsx

@@ -43,14 +43,12 @@ const WebvizContentOverlay: React.FC<InferProps<typeof propTypes>> = ({
             <div className="webviz-plugin-data-owner">
                 {contactPerson && "name" in contactPerson && (
                     <p>
-                        { /* @ts-expect-error - this is a very weird bug */}
                         <Icon name="person" style={{ marginRight: "5px" }} />
                         {contactPerson.name}
                     </p>
                 )}
                 {contactPerson && "email" in contactPerson && (
                     <p>
-                        { /* @ts-expect-error - this is a very weird bug */}
                         <Icon name="email" style={{ marginRight: "5px" }} />
                         <a href="mailto:{this.props.contactPerson.email}">
                             {contactPerson.email}
@@ -59,7 +57,6 @@ const WebvizContentOverlay: React.FC<InferProps<typeof propTypes>> = ({
                 )}
                 {contactPerson && "phone" in contactPerson && (
                     <p>
-                        { /* @ts-expect-error - this is a very weird bug */}
                         <Icon name="call" style={{ marginRight: "5px" }} />
                         {contactPerson.phone}
                     </p>

react/src/lib/components/WebvizPluginPlaceholder/components/WebvizContentOverlay.tsx

@@ -24,7 +24,6 @@ const WebvizToolbarButton: React.FC<WebvizToolbarButtonProps> = ({
     target,
 }) => {
     const createIcon = (useOnClick: boolean) => (
-        // @ts-expect-error - this is a very weird bug
         <Icon
             data={icon}
             className={classNames({