[DPF]: Possible improvements

[rubenthoms]

This issue serves as a collection pool for possible improvements to the layer framework that we come up with during the implementation of consumer modules (e.g. 3D viewer, Intersection, or WellLogViewer).

Improvements

• Pass localSettings and globalSettings as arguments to the layers' fetchData method

[Anders2303]

Here are some things I've noted while implementing the Well log viewer provider manager:

• In a data-accumulator method, the system crashes if you try accessing a non-existent setting (I'm reusing the same accumulator for multiple plots, and some plots accumulate some extra data). I needed to do a try/catch as a workaround, but I'd rather expect it to just return undefined

  // ! Will crash if provider does not have the setting
  if (args.getSetting(Setting.FOO) {
      // Do something ...        
  }

• Could be nice to be able to have a child limit on groups. I have some group types that only has on or two plot providers; I could manually fix the limit with isMoveAllowed and groupActions, but it'd be nice to have the manager do that for me
• If we have some generalized settings, like COLOR, it could be nice if the layer could override the label to be more specific, like plot providers calling the setting "curve color" (as opposed to needing a specific CURVE_COLOR setting)
• It could be nice to be able to hide un-important and related settings in collapsible sections. For example, some plots might have 6 different styling options

[jorgenherje]

I've experienced issue with crash due to intermediate state when selecting new settings when using the provider framework for the Intersection-module. When selecting a new field, I get isLoading === true, the settings are updated and stored data is updated as well, before setting isLoading === false again. However, the make-function for the layer is then called before fetchData(), and with isLoading === false we have updated settings and stored data, but the new data is not fetched yet. Thereby we have mismatch between settings and current data, and can not guard this using the isLoading-flag.

The crash is a result of throw Error due to mismatching between the new polyline from settings, and fetched intersection data which is not updated yet.

[jorgenherje]

Improve isValueValid and fixupValue for CustomSettingImplementation when the setting is getIsStatic returns true. Could be benefitial to provide e.g. validValue for a select, or minMax for a number input via the constructor. The SettingManager returns true for any value if the setting is static, thereby no validation or fixup is performed.

I would like: possibility to provide valid values or min/max in constructor, and perform fixup/validation of the static setting in constructor of SettingManager.

[jorgenherje]

Suggestion for group/shared settings:

• Allow control of enable- and visible-flag for group settings. As of now this can only be controlled for settings in a provider. E.g. extension length for intersection view, the setting should be set invisible if custom polyline is selected. This is can be controlled in the providers, but is affecting the setting for the group (intersection view).

[jorgenherje]

Suggestion/discussion:

Allow a group/view to fetch data? As of now we only have access to settingAttributesUpdater in defineDependencies

Ref comment during review:

#948 (comment)