Skip to content

Commit 9e4999e

Browse files
attiasasattiasas
committed
fix tests
1 parent f27dc32 commit 9e4999e

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

‎utils/results/conversion/simplejsonparser/simplejsonparser_test.go‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ func TestPrepareSimpleJsonVulnerabilities(t *testing.T) {
315315
IssueId: "XRAY-1",
316316
Cves: []formats.CveRow{{Id: "CVE-1", CvssV3: "5.3", CvssV3Vector: "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L", Cwe: []string{"cwe-1"}}},
317317
ImpactedDependencyDetails: formats.ImpactedDependencyDetails{
318-
SeverityDetails: formats.SeverityDetails{Severity: "High", SeverityNumValue: 23},
318+
SeverityDetails: formats.SeverityDetails{Severity: "High", SeverityNumValue: 27},
319319
ImpactedDependencyName: "component-A",
320320
// Direct
321321
Components: []formats.ComponentRow{{
@@ -330,7 +330,7 @@ func TestPrepareSimpleJsonVulnerabilities(t *testing.T) {
330330
IssueId: "XRAY-1",
331331
Cves: []formats.CveRow{{Id: "CVE-1", CvssV3: "5.3", CvssV3Vector: "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L", Cwe: []string{"cwe-1"}}},
332332
ImpactedDependencyDetails: formats.ImpactedDependencyDetails{
333-
SeverityDetails: formats.SeverityDetails{Severity: "High", SeverityNumValue: 23},
333+
SeverityDetails: formats.SeverityDetails{Severity: "High", SeverityNumValue: 27},
334334
ImpactedDependencyName: "component-B",
335335
// Direct
336336
Components: []formats.ComponentRow{{
@@ -345,7 +345,7 @@ func TestPrepareSimpleJsonVulnerabilities(t *testing.T) {
345345
IssueId: "XRAY-2",
346346
Cves: []formats.CveRow{{Id: "CVE-2", CvssV2: "5.0", CvssV2Vector: "CVSS:2.0/AV:N/AC:L/Au:N/C:N/I:N/A:P", Cwe: []string{"CWE-284", "NVD-CWE-noinfo"}}},
347347
ImpactedDependencyDetails: formats.ImpactedDependencyDetails{
348-
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 15},
348+
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 17},
349349
ImpactedDependencyName: "component-B",
350350
// Direct
351351
Components: []formats.ComponentRow{{
@@ -436,7 +436,7 @@ func TestPrepareSimpleJsonVulnerabilities(t *testing.T) {
436436
},
437437
}},
438438
ImpactedDependencyDetails: formats.ImpactedDependencyDetails{
439-
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 18},
439+
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 21},
440440
ImpactedDependencyName: "component-B",
441441
// Direct
442442
Components: []formats.ComponentRow{{
@@ -484,7 +484,7 @@ func TestPrepareSimpleJsonViolations(t *testing.T) {
484484
IssueId: "XRAY-1",
485485
Cves: []formats.CveRow{{Id: "CVE-1", CvssV3: "5.3", CvssV3Vector: "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L", Cwe: []string{"cwe-1"}}},
486486
ImpactedDependencyDetails: formats.ImpactedDependencyDetails{
487-
SeverityDetails: formats.SeverityDetails{Severity: "High", SeverityNumValue: 23},
487+
SeverityDetails: formats.SeverityDetails{Severity: "High", SeverityNumValue: 27},
488488
ImpactedDependencyName: "component-A",
489489
// Direct
490490
Components: []formats.ComponentRow{{
@@ -502,7 +502,7 @@ func TestPrepareSimpleJsonViolations(t *testing.T) {
502502
IssueId: "XRAY-1",
503503
Cves: []formats.CveRow{{Id: "CVE-1", CvssV3: "5.3", CvssV3Vector: "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L", Cwe: []string{"cwe-1"}}},
504504
ImpactedDependencyDetails: formats.ImpactedDependencyDetails{
505-
SeverityDetails: formats.SeverityDetails{Severity: "High", SeverityNumValue: 23},
505+
SeverityDetails: formats.SeverityDetails{Severity: "High", SeverityNumValue: 27},
506506
ImpactedDependencyName: "component-B",
507507
// Direct
508508
Components: []formats.ComponentRow{{
@@ -520,7 +520,7 @@ func TestPrepareSimpleJsonViolations(t *testing.T) {
520520
IssueId: "XRAY-2",
521521
Cves: []formats.CveRow{{Id: "CVE-2", CvssV2: "5.0", CvssV2Vector: "CVSS:2.0/AV:N/AC:L/Au:N/C:N/I:N/A:P", Cwe: []string{"CWE-284", "NVD-CWE-noinfo"}}},
522522
ImpactedDependencyDetails: formats.ImpactedDependencyDetails{
523-
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 15},
523+
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 17},
524524
ImpactedDependencyName: "component-B",
525525
// Direct
526526
Components: []formats.ComponentRow{{
@@ -539,7 +539,7 @@ func TestPrepareSimpleJsonViolations(t *testing.T) {
539539
LicenseRow: formats.LicenseRow{
540540
LicenseKey: "license-1",
541541
ImpactedDependencyDetails: formats.ImpactedDependencyDetails{
542-
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 15},
542+
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 17},
543543
ImpactedDependencyName: "component-B",
544544
Components: []formats.ComponentRow{{Name: "component-B", Location: &formats.Location{File: "descriptor.json"}}},
545545
},
@@ -635,7 +635,7 @@ func TestPrepareSimpleJsonViolations(t *testing.T) {
635635
},
636636
}},
637637
ImpactedDependencyDetails: formats.ImpactedDependencyDetails{
638-
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 18},
638+
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 21},
639639
ImpactedDependencyName: "component-B",
640640
// Direct
641641
Components: []formats.ComponentRow{{
@@ -654,7 +654,7 @@ func TestPrepareSimpleJsonViolations(t *testing.T) {
654654
LicenseRow: formats.LicenseRow{
655655
LicenseKey: "license-1",
656656
ImpactedDependencyDetails: formats.ImpactedDependencyDetails{
657-
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 15},
657+
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 17},
658658
ImpactedDependencyName: "component-B",
659659
// Direct
660660
Components: []formats.ComponentRow{{
@@ -770,7 +770,7 @@ func TestPrepareSimpleJsonJasIssues(t *testing.T) {
770770
{
771771
Finding: "result-msg",
772772
Location: formats.Location{File: "file", StartLine: 1, StartColumn: 2, EndLine: 3, EndColumn: 4, Snippet: "secret-snippet"},
773-
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 18},
773+
SeverityDetails: formats.SeverityDetails{Severity: "Low", SeverityNumValue: 21},
774774
ScannerInfo: formats.ScannerInfo{RuleId: "secret-rule-id", ScannerDescription: "rule-msg"},
775775
},
776776
},

‎utils/xray/scangraph/scangraph_test.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
package scangraph
22

33
import (
4-
"github.com/jfrog/jfrog-client-go/xray/services"
5-
"github.com/stretchr/testify/assert"
64
"reflect"
75
"testing"
6+
7+
"github.com/jfrog/jfrog-client-go/xray/services"
8+
"github.com/stretchr/testify/assert"
89
)
910

1011
func TestFilterResultIfNeeded(t *testing.T) {
@@ -84,7 +85,7 @@ func TestFilterResultIfNeeded(t *testing.T) {
8485
},
8586
},
8687
params: ScanGraphParams{
87-
severityLevel: 23,
88+
severityLevel: 30,
8889
},
8990
expected: services.ScanResponse{
9091
Violations: []services.Violation{

0 commit comments

Comments
 (0)