Skip to content

Commit b8bde76

Browse files
committed
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security into fix-get-severity-details-applicability-status-switch
2 parents 64151cb + d7849e1 commit b8bde76

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

jas/analyzermanager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323
const (
2424
ApplicabilityFeatureId = "contextual_analysis"
2525
AnalyzerManagerZipName = "analyzerManager.zip"
26-
defaultAnalyzerManagerVersion = "1.23.3"
26+
defaultAnalyzerManagerVersion = "1.23.9"
2727
analyzerManagerDownloadPath = "xsc-gen-exe-analyzer-manager-local/v1"
2828
analyzerManagerDirName = "analyzerManager"
2929
analyzerManagerExecutableName = "analyzerManager"

utils/results/common.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1103,10 +1103,12 @@ func getDataFromNode(node *xrayUtils.GraphNode, parsed *datastructures.Set[strin
11031103
}
11041104

11051105
func getNodeDirectDependencies(node *xrayUtils.GraphNode) (dependencies *[]string) {
1106-
dependencies = &[]string{}
1106+
depSet := datastructures.MakeSet[string]()
11071107
for _, dep := range node.Nodes {
1108-
*dependencies = append(*dependencies, techutils.XrayComponentIdToCdxComponentRef(dep.Id))
1108+
depSet.Add(techutils.XrayComponentIdToCdxComponentRef(dep.Id))
11091109
}
1110+
dependencies = &[]string{}
1111+
*dependencies = depSet.ToSlice()
11101112
return
11111113
}
11121114

utils/results/common_test.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1310,7 +1310,7 @@ func TestDepTreeToSbom(t *testing.T) {
13101310
expectedDependencies: &[]cyclonedx.Dependency{
13111311
{
13121312
Ref: "npm:root:1.0.0",
1313-
Dependencies: &[]string{"npm:A:1.0.1", "npm:D:2.0.0", "npm:B:1.0.0"},
1313+
Dependencies: &[]string{"npm:A:1.0.1", "npm:B:1.0.0", "npm:D:2.0.0"},
13141314
},
13151315
{
13161316
Ref: "npm:A:1.0.1",
@@ -1456,6 +1456,13 @@ func TestDepTreeToSbom(t *testing.T) {
14561456
for _, test := range tests {
14571457
t.Run(test.name, func(t *testing.T) {
14581458
components, dependencies := DepsTreeToSbom(test.depTrees...)
1459+
if dependencies != nil {
1460+
for i := range *dependencies {
1461+
if (*dependencies)[i].Dependencies != nil {
1462+
sort.Strings(*(*dependencies)[i].Dependencies)
1463+
}
1464+
}
1465+
}
14591466
assert.Equal(t, test.expectedComponents, components)
14601467
assert.Equal(t, test.expectedDependencies, dependencies)
14611468
})

0 commit comments

Comments
 (0)