bugfix(api) Fixed API returned Content-Type header (#1705)

Author: piotrkreft

CHANGELOG.md

@@ -1,4 +1,7 @@
 ## CHANGELOG FOR 1.1.x
+#### 1.1.4
+- bugfix [#1704](https://github.com/ergonode/backend/issues/1704) Fixed API returned `Content-Type` header (piotrkreft)
+
 #### 1.1.1
 - bugfix [#1519](https://github.com/ergonode/backend/issues/1519) Fixed caught exception in DTOInputValueResolver (piotrkreft)
 

module/api/src/Application/EventListener/ExceptionListener.php

@@ -12,6 +12,7 @@
 use Ergonode\Api\Application\Mapper\ExceptionMapperInterface;
 use Ergonode\Api\Application\Response\ExceptionResponse;
 use Ergonode\SharedKernel\Application\Serializer\SerializerInterface;
+use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Event\ExceptionEvent;
 use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
@@ -71,10 +72,11 @@ private function mapToResponse(\Throwable $exception): Response
             $headers = $exception->getHeaders();
         }
 
-        return new Response(
+        return new JsonResponse(
             $this->serializer->serialize($exception),
             $statusCode,
             $headers,
+            true,
         );
     }
 }

module/api/src/Application/EventListener/ResponseSubscriber.php

@@ -12,6 +12,7 @@
 use Ergonode\SharedKernel\Application\Serializer\SerializerInterface;
 use Ergonode\SharedKernel\Domain\AbstractId;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Event\ViewEvent;
@@ -34,9 +35,11 @@ public function onViewEvent(ViewEvent $event): void
 
         $body = $this->serializer->serialize($result);
 
-        $response = new Response(
+        $response = new JsonResponse(
             $body,
             $this->resolveCode($event),
+            [],
+            true,
         );
 
         $event->setResponse($response);

module/api/tests/Application/EventListener/ExceptionListenerTest.php

@@ -15,7 +15,7 @@
 use Ergonode\SharedKernel\Application\Serializer\SerializerInterface;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
-use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpKernel\Event\ExceptionEvent;
 use Symfony\Component\Messenger\Exception\HandlerFailedException;
 use Symfony\Component\Security\Core\Exception\AuthenticationCredentialsNotFoundException;
@@ -150,7 +150,7 @@ public function testInvokeWithoutMapping(): void
         $this->event
             ->expects($this->once())
             ->method('setResponse')->willreturnCallback(function ($response): void {
-                $this->assertEquals(Response::class, get_class($response));
+                $this->assertEquals(JsonResponse::class, get_class($response));
                 $this->assertEquals(500, $response->getStatusCode());
             });
 
@@ -171,7 +171,7 @@ public function testInvokeWithoutMappingWithHandlerFailedException(): void
         $this->event
             ->expects($this->once())
             ->method('setResponse')->willreturnCallback(function ($response): void {
-                $this->assertEquals(Response::class, get_class($response));
+                $this->assertEquals(JsonResponse::class, get_class($response));
                 $this->assertEquals(500, $response->getStatusCode());
             });
 
@@ -201,7 +201,7 @@ public function testInvokeWithMappingWithHandlerFailedExceptio(): void
         $this->event
             ->expects($this->once())
             ->method('setResponse')->willreturnCallback(function ($response): void {
-                $this->assertEquals(Response::class, get_class($response));
+                $this->assertEquals(JsonResponse::class, get_class($response));
                 $this->assertEquals(403, $response->getStatusCode());
             });
 
@@ -228,7 +228,7 @@ public function testInvokeWithMapping(): void
         $this->event
             ->expects($this->once())
             ->method('setResponse')->willreturnCallback(function ($response): void {
-                $this->assertEquals(Response::class, get_class($response));
+                $this->assertEquals(JsonResponse::class, get_class($response));
                 $this->assertEquals(403, $response->getStatusCode());
             });
 

module/api/tests/Application/EventListener/ResponseSubscriberTest.php

@@ -46,6 +46,7 @@ public function testOnViewEvent(ViewEvent $event, Response $expectedResponse): v
 
         $this->assertEquals($expectedResponse->getContent(), $event->getResponse()->getContent());
         $this->assertEquals($expectedResponse->getStatusCode(), $event->getResponse()->getStatusCode());
+        $this->assertEquals('application/json', $event->getResponse()->headers->get('Content-Type'));
     }
 
     public function eventProvider(): array

module/category/src/Application/Controller/Api/CategoryTypeConfigurationAction.php

@@ -14,6 +14,7 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted;
 use Swagger\Annotations as SWG;
 use Symfony\Component\Form\FormFactoryInterface;
+use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
 
@@ -68,6 +69,6 @@ public function __invoke(string $type): Response
 
         $result = json_encode($this->liForm->transform($form), JSON_THROW_ON_ERROR, 512);
 
-        return new Response($result);
+        return new JsonResponse($result, Response::HTTP_OK, [], true);
     }
 }

module/channel/src/Application/Controller/Api/ChannelTypeConfigurationAction.php

@@ -11,6 +11,7 @@
 use Limenius\Liform\Liform;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted;
 use Swagger\Annotations as SWG;
+use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
 use Ergonode\Channel\Application\Provider\ChannelFormFactoryProvider;
@@ -78,6 +79,6 @@ public function __invoke(string $type): Response
 
         $result = json_encode($this->liForm->transform($form), JSON_THROW_ON_ERROR, 512);
 
-        return new Response($result);
+        return new JsonResponse($result, Response::HTTP_OK, [], true);
     }
 }

module/importer/src/Application/Controller/Api/Source/SourceTypeConfigurationAction.php

@@ -13,6 +13,7 @@
 use Limenius\Liform\Liform;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted;
 use Swagger\Annotations as SWG;
+use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Annotation\Route;
 use Ergonode\Importer\Infrastructure\Provider\SourceTypeProvider;
@@ -80,6 +81,6 @@ public function __invoke(string $type): Response
         $form = $this->factoryProvider->provide($type)->create();
         $result = json_encode($this->liform->transform($form), JSON_THROW_ON_ERROR, 512);
 
-        return new Response($result);
+        return new JsonResponse($result, Response::HTTP_OK, [], true);
     }
 }