improve logigng to review_submission

Author: tonyqiu123

backend/apps/events/views.py

@@ -1,5 +1,7 @@
 import json
 import uuid
+import logging
+import traceback
 from datetime import timedelta
 import pytz
 
@@ -27,6 +29,8 @@
 
 from .models import Events, EventSubmission, EventInterest, EventDates
 
+logger = logging.getLogger(__name__)
+
 
 @api_view(["GET"])
 @permission_classes([AllowAny])
@@ -674,36 +678,118 @@ def get_submissions(request):
 @jwt_required
 @ratelimit(key="ip", rate="100/hr", block=True)
 def review_submission(request, event_id):
-    """Approve or reject submission
-    """
+    """Approve or reject submission"""
     try:
-        data = json.loads(request.body)
-        event = get_object_or_404(Events, id=event_id)
-        submission = event.submission
-        if not submission:
-            return Response({"message": "No submission found for this event"}, status=status.HTTP_404_NOT_FOUND)
+        logger.info(f"[review_submission] Starting review for event_id={event_id}, user_id={request.user_id}")
+        
+        # Parse request body
+        try:
+            data = json.loads(request.body)
+            logger.debug(f"[review_submission] Parsed request data: {data}")
+        except json.JSONDecodeError as e:
+            logger.error(f"[review_submission] JSON decode error: {e}, body: {request.body}")
+            return Response(
+                {"message": "Invalid JSON in request body", "error": str(e)}, 
+                status=status.HTTP_400_BAD_REQUEST
+            )
+        
+        # Get event
+        try:
+            event = get_object_or_404(Events, id=event_id)
+            logger.debug(f"[review_submission] Found event: id={event.id}, title={event.title}, status={event.status}")
+        except Exception as e:
+            logger.error(f"[review_submission] Error getting event {event_id}: {e}")
+            logger.error(f"[review_submission] Traceback: {traceback.format_exc()}")
+            return Response(
+                {"message": f"Event not found: {event_id}", "error": str(e)}, 
+                status=status.HTTP_404_NOT_FOUND
+            )
+        
+        # Get submission (safer query method)
+        try:
+            submission = EventSubmission.objects.filter(created_event=event).first()
+            if not submission:
+                logger.warning(f"[review_submission] No submission found for event_id={event_id}")
+                return Response(
+                    {"message": "No submission found for this event"}, 
+                    status=status.HTTP_404_NOT_FOUND
+                )
+            logger.debug(f"[review_submission] Found submission: id={submission.id}, submitted_by={submission.submitted_by}")
+        except Exception as e:
+            logger.error(f"[review_submission] Error getting submission for event {event_id}: {e}")
+            logger.error(f"[review_submission] Traceback: {traceback.format_exc()}")
+            return Response(
+                {"message": "Error retrieving submission", "error": str(e)}, 
+                status=status.HTTP_500_INTERNAL_SERVER_ERROR
+            )
+        
+        # Get action
         action = data.get("action")
+        if not action:
+            logger.warning(f"[review_submission] No action provided in request data")
+            return Response(
+                {"message": "Action is required. Use 'approve' or 'reject'"}, 
+                status=status.HTTP_400_BAD_REQUEST
+            )
+        
+        logger.info(f"[review_submission] Processing action={action} for event_id={event_id}")
 
         if action == "approve":
-            event.status = "CONFIRMED"
-            event.save()
-            submission.reviewed_at = timezone.now()
-            submission.reviewed_by = request.user_id
-            submission.save()
-            return Response({"message": "Event approved", "event_id": event.id})
+            try:
+                event.status = "CONFIRMED"
+                event.save()
+                logger.debug(f"[review_submission] Updated event status to CONFIRMED")
+                
+                submission.reviewed_at = timezone.now()
+                submission.reviewed_by = request.user_id
+                submission.save()
+                logger.info(f"[review_submission] Successfully approved event_id={event_id}")
+                
+                return Response({"message": "Event approved", "event_id": event.id})
+            except Exception as e:
+                logger.error(f"[review_submission] Error approving event {event_id}: {e}")
+                logger.error(f"[review_submission] Traceback: {traceback.format_exc()}")
+                return Response(
+                    {"message": "Error approving event", "error": str(e)}, 
+                    status=status.HTTP_500_INTERNAL_SERVER_ERROR
+                )
 
         elif action == "reject":
-            submission.reviewed_at = timezone.now()
-            submission.reviewed_by = request.user_id
-            submission.save()
-            if event:
-                event.status = "CANCELLED"
-                event.save()
-            return Response({"message": "Event rejected"})
+            try:
+                submission.reviewed_at = timezone.now()
+                submission.reviewed_by = request.user_id
+                submission.save()
+                logger.debug(f"[review_submission] Updated submission review info")
+                
+                if event:
+                    event.status = "CANCELLED"
+                    event.save()
+                    logger.debug(f"[review_submission] Updated event status to CANCELLED")
+                
+                logger.info(f"[review_submission] Successfully rejected event_id={event_id}")
+                return Response({"message": "Event rejected"})
+            except Exception as e:
+                logger.error(f"[review_submission] Error rejecting event {event_id}: {e}")
+                logger.error(f"[review_submission] Traceback: {traceback.format_exc()}")
+                return Response(
+                    {"message": "Error rejecting event", "error": str(e)}, 
+                    status=status.HTTP_500_INTERNAL_SERVER_ERROR
+                )
 
-        return Response({"message": "Invalid action. Use 'approve' or 'reject'"}, status=status.HTTP_400_BAD_REQUEST)
+        logger.warning(f"[review_submission] Invalid action: {action}")
+        return Response(
+            {"message": "Invalid action. Use 'approve' or 'reject'"}, 
+            status=status.HTTP_400_BAD_REQUEST
+        )
+        
     except Exception as e:
-        return Response({"message": str(e)}, status=status.HTTP_500_INTERNAL_SERVER_ERROR)
+        logger.error(f"[review_submission] Unexpected error in review_submission: {e}")
+        logger.error(f"[review_submission] Traceback: {traceback.format_exc()}")
+        logger.error(f"[review_submission] Request data: event_id={event_id}, user_id={getattr(request, 'user_id', 'unknown')}")
+        return Response(
+            {"message": "Internal server error", "error": str(e)}, 
+            status=status.HTTP_500_INTERNAL_SERVER_ERROR
+        )
 
 
 @api_view(["GET"])