wip testing

Author: ericcornelissen

src/internal/tmp.js

@@ -0,0 +1,7 @@
+export function chain({ escape, flagProtect, quote }) {
+  return quote(flagProtect(escape(arg)));
+}
+
+export function id(arg) {
+  return arg;
+}

src/internal/win/cmd.js

@@ -70,6 +70,6 @@ export function getQuoteFunction() {
  * @returns {function(string): string} A function to protect against flag injection.
  */
 export function getFlagProtectionFunction() {
-  const leadingHyphensAndSlashes = new RegExp(/^(?:-+|\/+)/);
+  const leadingHyphensAndSlashes = new RegExp(/^(?:-|\/)+/);
   return (arg) => arg.replace(leadingHyphensAndSlashes, "");
 }

src/internal/win/no-shell.js

@@ -49,6 +49,6 @@ export function getQuoteFunction() {
  * @returns {function(string): string} A function to protect against flag injection.
  */
 export function getFlagProtectionFunction() {
-  const leadingHyphensAndSlashes = new RegExp(/^(?:-+|\/+)/);
+  const leadingHyphensAndSlashes = new RegExp(/^(?:-|\/)+/);
   return (arg) => arg.replace(leadingHyphensAndSlashes, "");
 }

src/internal/win/powershell.js

@@ -16,7 +16,6 @@ export function getEscapeFunction() {
   const newlines = new RegExp(/\n/g);
   const backticks = new RegExp(/`/g);
   const redirects = new RegExp(/(^|[\s\u0085])([*1-6]?)(>)/g);
-  const hyphens = new RegExp(/([\s\u0085])-/g);
   const specials1 = new RegExp(/(^|[\s\u0085])([#\-:<@\]])/g);
   const specials2 = new RegExp(/([$&'(),;{|}‘’‚‛“”„])/g);
 
@@ -34,7 +33,6 @@ export function getEscapeFunction() {
       .replace(newlines, " ")
       .replace(backticks, "``")
       .replace(redirects, "$1$2`$3")
-      .replace(hyphens, "$1`-")
       .replace(specials1, "$1`$2")
       .replace(specials2, "`$1");
 
@@ -114,6 +112,6 @@ export function getQuoteFunction() {
  * @returns {function(string): string} A function to protect against flag injection.
  */
 export function getFlagProtectionFunction() {
-  const leadingHyphensAndSlashes = new RegExp(/^(?:-+|\/+)/);
+  const leadingHyphensAndSlashes = new RegExp(/^(?:-|\/)+/);
   return (arg) => arg.replace(leadingHyphensAndSlashes, "");
 }

temp.js

@@ -1,49 +1,43 @@
-import { exec } from "node:child_process";
+import { execSync } from "node:child_process";
 import { Shescape } from "shescape";
 
 const options = { shell: "powershell" };
 const shescape = new Shescape({ shell: "powershell" });
 
-exec(`gh ${shescape.escape("--help")}`, options, (error) => {
-  if (error) {
-    console.log("gh --help : error");
-  } else {
-    console.log("gh --help : no error");
-  }
-});
-exec(`gh ${shescape.escape("`--help")}`, options, (error) => {
-  if (error) {
-    console.log("gh `--help : error");
-  } else {
-    console.log("gh `--help : no error");
-  }
-});
-exec(`gh ${shescape.escape("``--help")}`, options, options, (error) => {
-  if (error) {
-    console.log("gh ``--help : error");
-  } else {
-    console.log("gh ``--help : no error");
-  }
-});
+try {
+  execSync(`gh ${shescape.escape("--help")}`, options);
+  console.log("gh --help : no error");
+} catch {
+  console.log("gh --help : error");
+}
+try {
+  execSync(`gh ${shescape.escape("`--help")}`, options);
+  console.log("gh `--help : no error");
+} catch {
+  console.log("gh `--help : error");
+}
+try {
+  execSync(`gh ${shescape.escape("``--help")}`, options, options);
+  console.log("gh ``--help : no error");
+} catch {
+  console.log("gh ``--help : error");
+}
 
-exec(`gh ${shescape.quote("--help")}`, options, (error) => {
-  if (error) {
-    console.log("gh '--help': error");
-  } else {
-    console.log("gh '--help': no error");
-  }
-});
-exec(`gh ${shescape.quote("`--help")}`, options, (error) => {
-  if (error) {
-    console.log("gh '`--help': error");
-  } else {
-    console.log("gh '`--help': no error");
-  }
-});
-exec(`gh ${shescape.quote("``--help")}`, options, (error) => {
-  if (error) {
-    console.log("gh '``--help': error");
-  } else {
-    console.log("gh '``--help': no error");
-  }
-});
+try {
+  execSync(`gh ${shescape.quote("--help")}`, options);
+  console.log("gh '--help': no error");
+} catch {
+  console.log("gh '--help': error");
+}
+try {
+  execSync(`gh ${shescape.quote("`--help")}`, options);
+  console.log("gh '`--help': no error");
+} catch {
+  console.log("gh '`--help': error");
+}
+try {
+  execSync(`gh ${shescape.quote("``--help")}`, options);
+  console.log("gh '``--help': no error");
+} catch {
+  console.log("gh '``--help': error");
+}