Align Stubscape behavior for illegal arguments with Shescape (#2382)

Author: ericcornelissen

CHANGELOG.md

@@ -10,7 +10,8 @@ Versioning].
 ## [Unreleased]
 
 - Expand support for `--enable-experimental-regexp-engine`. ([#2358])
-- Improve rejecting non-array inputs to `escapeAll` & `quoteAll`. ([#2363])
+- Improve rejecting non-array inputs to `escapeAll` & `quoteAll`. ([#2363],
+  [#2382])
 
 ## [2.1.8] - 2026-01-25
 
@@ -383,6 +384,7 @@ Versioning].
 [#2342]: https://github.com/ericcornelissen/shescape/pull/2342
 [#2358]: https://github.com/ericcornelissen/shescape/pull/2358
 [#2363]: https://github.com/ericcornelissen/shescape/pull/2363
+[#2382]: https://github.com/ericcornelissen/shescape/pull/2382
 [552e8ea]: https://github.com/ericcornelissen/shescape/commit/552e8eab56861720b1d4e5474fb65741643358f9
 [keep a changelog]: https://keepachangelog.com/en/1.0.0/
 [semantic versioning]: https://semver.org/spec/v2.0.0.html

src/testing.js

@@ -3,7 +3,7 @@
  * @license MPL-2.0
  */
 
-import { checkedToString } from "./internal/reflection.js";
+import { checkedToString, ensureArray } from "./internal/reflection.js";
 
 /**
  * A list of example shell injection strings to test whether or not a function
@@ -68,6 +68,7 @@ export class Stubscape {
   }
 
   escapeAll(args) {
+    ensureArray(args);
     return args.map((arg) => this.escape(arg));
   }
 
@@ -80,6 +81,7 @@ export class Stubscape {
   }
 
   quoteAll(args) {
+    ensureArray(args);
     return args.map((arg) => this.quote(arg));
   }
 }

test/integration/testing/functional.test.js

@@ -15,7 +15,7 @@ import {
   Throwscape,
 } from "shescape/testing";
 
-import { arbitrary } from "../_.js";
+import { arbitrary, constants } from "../_.js";
 
 test("injection strings", (t) => {
   t.true(Array.isArray(injectionStrings));
@@ -77,7 +77,13 @@ testProp(
 
 testProp(
   "Stubscape#escape (stubscape =~ shescape)",
-  [fc.anything(), arbitrary.shescapeOptions()],
+  [
+    fc.oneof(
+      fc.anything(),
+      fc.constantFrom(...constants.illegalArguments.map((arg) => arg.value)),
+    ),
+    arbitrary.shescapeOptions(),
+  ],
   (t, arg, options) => {
     let result, stubResult, errored, stubErrored;
 
@@ -109,7 +115,15 @@ testProp(
 
 testProp(
   "Stubscape#escapeAll (stubscape =~ shescape)",
-  [fc.anything(), arbitrary.shescapeOptions()],
+  [
+    fc.oneof(
+      fc.anything(),
+      fc.constantFrom(
+        ...constants.illegalArgumentLists.map((args) => args.value),
+      ),
+    ),
+    arbitrary.shescapeOptions(),
+  ],
   (t, args, options) => {
     let result, stubResult, errored, stubErrored;
 
@@ -141,7 +155,13 @@ testProp(
 
 testProp(
   "Stubscape#quote, with shell (stubscape =~ shescape)",
-  [fc.anything(), arbitrary.shescapeOptions()],
+  [
+    fc.oneof(
+      fc.anything(),
+      fc.constantFrom(...constants.illegalArguments.map((arg) => arg.value)),
+    ),
+    arbitrary.shescapeOptions(),
+  ],
   (t, arg, options) => {
     let result, stubResult, errored, stubErrored;
 
@@ -185,7 +205,15 @@ test("stubscape#quote with shell set to false", (t) => {
 
 testProp(
   "Stubscape#quoteAll, with shell (stubscape =~ shescape)",
-  [fc.anything(), arbitrary.shescapeOptions()],
+  [
+    fc.oneof(
+      fc.anything(),
+      fc.constantFrom(
+        ...constants.illegalArgumentLists.map((args) => args.value),
+      ),
+    ),
+    arbitrary.shescapeOptions(),
+  ],
   (t, args, options) => {
     let result, stubResult, errored, stubErrored;